eclipse-basyx / basyx-databridge

Eclipse Public License 2.0
9 stars 14 forks source link

OPC UA - Missing Security settings #241

Closed BlackRose01 closed 1 year ago

BlackRose01 commented 1 year ago

Hi,

in my project I need to transfer data from an OPC UA server to the AAS Server via the AAS Databridge. The problem is that the OpcuaConsumerConfiguration only handles connection with SecurityPolicies None but our OPC UA server requires a the Policy Basic256Sha256.

So my question is if I just misunderstood the configuration and it is possible after all or this is really missing. If this is missing, would it be possible to add this?

KR, BlackRose01

FrankSchnicke commented 1 year ago

This is currently missing. However, feel free to raise a pull request adding this feature. Since we're directly mapping the JSON configuration files to the java classes, adding the needed fields to the OpcuaConsumerConfiguration and changing the getConnectionURI method is sufficient.

Would this be an idea?

BlackRose01 commented 1 year ago

This is ok. Are there any requirements to create a pull request like signing the Eclipse Contributor Agreement (ECA) or a name convention for the branch?

FrankSchnicke commented 1 year ago

Yes, you have to sign the ECA. Just raise a PR on main, there's no need for a specific branch name

BlackRose01 commented 1 year ago

I created the Pull Request with the necessary changes.

BlackRose01 commented 1 year ago

Is there any schedule when the new Docker image will be published on Docker Hub?

FrankSchnicke commented 1 year ago

In the next release, we would like to also include https://github.com/eclipse-basyx/basyx-databridge/pull/234 which will be merged most likely this week.

However, I can gladly push a SNAPSHOT image to DockerHub if you need an image on DockerHub that includes your PR at an earlier time.

BlackRose01 commented 1 year ago

That would be great. So I can test the implementation and push our project forward.

FrankSchnicke commented 1 year ago

I pushed the snapshot version to DockerHub.