search

eclipse-che / che

Kubernetes based Cloud Development Environments for Enterprise Teams
http://eclipse.org/che
Eclipse Public License 2.0
6.95k stars 1.19k forks source link

Workspace start page goes to cyclic reload if refresh token mode is applied #23028

Closed vinokurig closed 1 month ago

vinokurig commented 1 month ago

Describe the bug

Workspace start dashboard page reloads cyclically, if refresh token mode is applied. A new personal access token is created on each page restart.

Che version

7.88@latest

Steps to reproduce

  1. Configure GitHub oauth
  2. Apply refresh token mode
  3. Start a workspace from a GitHub repository with a devfile.

Expected behavior

Workspace starts after only one page refresh.

Runtime

OpenShift

Screenshots

No response

Installation method

chectl/next

Environment

macOS

Eclipse Che Logs

No response

Additional context

No response

vinokurig commented 1 month ago
Token expiration period for supported git porviders: Provider name Expiration time
GitHub SAAS (github.com) no expiration
GitHub Enterprise Server no expiration
GitLab SAAS (gitlab.com) 2 hours
GitLab Server 2 hours
Bitbucket SAAS (bitbucket.org) 2 hours
Bitbucket Server 90 days
Microsoft Azure Devops 1 hour
ibuziuk commented 1 month ago

@vinokurig thanks for investigation, we can skip GitHub in this case and refresh tokens every time for other providers if the property is enabled - https://eclipse.dev/che/docs/stable/administration-guide/configuring-oauth-for-git-providers/ (we also need to mention that in the docs).

vinokurig commented 1 month ago

The issue is relevant for Azure devops as well.

ibuziuk commented 1 month ago

Moving to P1 to unblock the 7.89.0 release