eclipse-edc / MinimumViableDataspace

Guidance on documentation, scripts and integration steps on using the EDC project results
Apache License 2.0
61 stars 169 forks source link

feat: added Contract Agreement ID call to the collection #353

Closed MohamedFaalil closed 1 month ago

MohamedFaalil commented 1 month ago

What this PR changes/adds

This PR adds a new GET call to the Postman collection, called "Get Agreement ID". The new call hits the following endpoint:
/api/management/v3/contractnegotiations/{negotiation_id}.

Why it does that

The existing "Get Contract Negotiations" API call fetches all available negotiations for a consumer, but for beginners, it can be cumbersome to get the entire list and search for a specific negotiation by ID. This new API call allows users to directly retrieve a specific negotiation by its negotiation ID, making the process simpler and more efficient for users who already have the ID.

Further notes

No other significant areas of the code were changed. The addition is limited to the Postman collection.

_Please be sure to take a look at the contributing guidelines and our etiquette for pull requests._

paullatzelsperger commented 1 month ago

@MohamedFaalil don't submit surprise PRs. Read our contribution guidelines. The second bullet point clearly requires you to open a discussion/issue first.

In this particular case there is another effort going on which will influence your PR.

github-actions[bot] commented 1 month ago

This pull request is stale because it has been open for 7 days with no activity.

github-actions[bot] commented 1 month ago

This pull request was closed because it has been inactive for 7 days since being marked as stale.