search

eclipse-egit / egit

EGit, the git integration of Eclipse IDE
https://www.eclipse.org/egit/
Eclipse Public License 2.0
17 stars 7 forks source link

Background Colors in History Page could be improved for Platforms "Light (Preview)" theme #57

Open BeckerWdf opened 4 days ago

BeckerWdf commented 4 days ago

Version

7.0.0

Operating System

MacOS

Eclipse version

2023-09

Bug description

Platform currently is improving their light theme. This is not yet finished but already available as a separate "Preview" theme called "Light (Preview)". The main idea of the theme changes are to only have the editor in a bright white background but all the other views around it in background that is "dimmed" a bit. For more details see: https://github.com/eclipse-platform/eclipse.platform.ui/issues/2114

Actual behavior

With this theme enabled the egit history page now looks like this: image

Expected behavior

I am wondering if the "styled text" should fill up the complete area of the scrolled composite. This could be a bug that was not visible up to now because the background color of the "styled text" and the "scrolled composite" have been identical.

Relevant log output

No response

Other information

No response

tomaswolf commented 4 days ago

The tree on the right (yellow border in your screenshot) has background-color: inherit. Apparently Platform is only dimming certain controls.

On the left: apparently Platform changes the background of StyledText in views. We do programmatically set the background of the scrolled composite to that of the viewer.

I don't think this "dimming" is a good idea at all; note that the gray header lines now have a low contrast. (And the same for the file tree view on the right; it also shows sometimes file names in gray.) This all worked well with the normal white backgrounds, but now it may no longer be good. So more changes would be needed.

As for the source viewer not taking the whole area: looks a bit strange (is the source viewer even cut off at the right?). But it's possible that the viewer does not grab all available space.

Note that any changes must work well not only for this newfangled new theme but also for the old (current) one.

BeckerWdf commented 3 days ago

Note that any changes must work well not only for this newfangled new theme but also for the old (current) one.

The plan is that the "Light (Preview)" theme replaces the current "Light" theme once we have ironed out major issues of it.

tomaswolf commented 1 day ago

Note that any changes must work well not only for this newfangled new theme but also for the old (current) one.

The plan is that the "Light (Preview)" theme replaces the current "Light" theme once we have ironed out major issues of it.

Doesn't matter. EGit is supposed to also work on older Eclipses. Any change must work well with both.

Bananeweizen commented 23 hours ago

Side tracking: Is there an issue for the Light theme to be discussed? IMO making everything gray on gray is a usability disaster. I don't know why more and more tools come with themes that have far less contrast and shapes than before.