search

eclipse-glsp / glsp

Graphical language server platform for building web-based diagram editors
https://www.eclipse.dev/glsp
Other
195 stars 31 forks source link

Make important configuration constants available in DI container #960

Closed tortmayr closed 1 year ago

tortmayr commented 1 year ago

Currently certain parts of the diagram configuration and setup/initialization happen outside of the diagram container. This has two negative side effects: 1) Import configuration constants like "diagramType", "clientSessionId,sourceUri` etc are not directly available in the diagram container. 2) A lot of common code like setting up a new client session is done outside of the container and therefore dupliacted for each application (integration)

We could introduce something like GlspDiagramOptions which provides these import configuration constants. They only thing that application than have to do is to configure the GlspDiagramOptions object. The rest (like session, server connection` can than be handled generically inside of the diagram container.

tortmayr commented 1 year ago

Required changes in following repositories