eclipse-iceoryx / iceoryx-rs

Rust wrapper for Eclipse iceoryx™ - true zero-copy inter-process-communication
Apache License 2.0
89 stars 16 forks source link

iox-#17 Fix cargo build #19

Closed adoerr closed 2 years ago

adoerr commented 2 years ago

Fixes #17

The build issue is not related to libacl1-dev.

The problem actually seems to be that the current make_and_install() function is not dealing with the cpptoml dependency of iceoryx_posh correctly.

This in turn leads to a failure with the cmake configuration of iceoryx_posh. You can check this by inspecting the ./target/iceoryx-install/include/* folders. Basically the iceoryx_posh include folder is missing, leading to the error message referenced in the issue.

The PR essentially just mimics the recommended way to build iceoryx itself. Admittedly this is not ideal in terms of minimal compilation. On the other hand, it seems to work reliably. Please, feel free to optimize!

Sorry for the non-standard naming of the branch! Should have checked the iceoyx contribution guidelines earlier.

I have also taken the liberty to bump ICEORYX_VERSION to v2.0.2.

Signed-off-by: adoerr 0xad@gmx.net

Pre-Review Checklist for the PR Author

  1. [x ] Code follows the Rust coding style and is formatted with rustfmt
  2. [ ] Branch follows the naming format (iox-#123-this-is-a-branch)
  3. [ ] Commits messages are according to this guideline
  4. [x ] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  5. [x ] Relevant issues are linked
  6. [x ] Add sensible notes for the reviewer
  7. [x ] All checks have passed (except task-list-completed)
  8. [x ] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [ ] All open points are addressed and tracked via issues

References