search

eclipse-iceoryx / iceoryx-rs

Rust wrapper for Eclipse iceoryx™ - true zero-copy inter-process-communication
Apache License 2.0
89 stars 16 forks source link

iox-#17: Fix cargo build #20

Closed adoerr closed 2 years ago

adoerr commented 2 years ago

Fixes #17

The build issue is not related to libacl1-dev.

The problem actually seems to be that the current make_and_install() function is not dealing with the cpptoml dependency of iceoryx_posh correctly.

This in turn leads to a failure with the cmake configuration of iceoryx_posh. You can check this by inspecting the ./target/iceoryx-install/include/* folders. Basically the iceoryx_posh include folder is missing, leading to the error message referenced in the issue.

The PR essentially just mimics the recommended way to build iceoryx itself. Admittedly this is not ideal in terms of minimal compilation. On the other hand, it seems to work reliably. Please, feel free to optimize!

I have also taken the liberty to bump ICEORYX_VERSION to v2.0.2.

Pre-Review Checklist for the PR Author

  1. [x ] Code follows the Rust coding style and is formatted with rustfmt
  2. [x ] Branch follows the naming format (iox-#123-this-is-a-branch)
  3. [ ] Commits messages are according to this guideline
  4. [x ] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  5. [x ] Relevant issues are linked
  6. [x ] Add sensible notes for the reviewer
  7. [x ] All checks have passed (except task-list-completed)
  8. [ x] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [ ] All open points are addressed and tracked via issues

References

dkroenke commented 2 years ago

@adoerr For the eclipsefdn/eca check you need to sign the ECA in your Eclipse Account with the E-Mail address that you have used for signing the commits.

elBoberido commented 2 years ago

@adoerr #21 will abort the build process early if iceoryx cannot be build. With that we should be able to find the root cause of your issue.

I also added a naive clippy fix but I like your one more, so please don't dismiss it when you rebase onto master

adoerr commented 2 years ago

@elBoberido thanks for looking into this!

This PR is basically just a quick-and-dirty solution that allowed me to compile iceoryx-rs somehow. So it is probably best to close this PR and continue with #21.

elBoberido commented 2 years ago

We can close this PR but it would be nice to get your fix for the recursion issue in the Debug impl. Maybe I can cherry pick from your branch

elBoberido commented 2 years ago

Closed in favor of #21. Relevant commits are cherry-picked to that PR