Closed mikebentley15 closed 1 month ago
After this review goes through, I may make another PR to redo this change for version v2.90 to integrate with our pipeline.
After this review goes through, I may make another PR to redo this change for version v2.90 to integrate with our pipeline.
There is no branch for v2.90. It is only a tag and therefore there is nothing a PR could be merged to. If you need this for your internal pipeline, you need to either carry a patch or update to the latest main branch.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.23%. Comparing base (
912931a
) to head (21f6d09
). Report is 23 commits behind head on main.
@mikebentley15 thanks very much for your contribution. I think I already mentioned it above, we are currently working on iceoryx2 which is written in Rust and will have C and C++ bindings with the next release. We will also present it in the iceoryx developer meetup next week on Tuesday. We would also be happy to hear what you are using iceoryx for :)
@elBoberido, you're welcome! It's pretty cool that you have iceoryx2 implemented in Rust. I'm using iceoryx indirectly via Cyclone DDS. Cheers!
Notes for Reviewer
The macros
ENUM
andCLASS
are very generic names and can potentially cause naming conflicts with user code or other third-party libraries. These macros are intended to make the headers compatible with both C and C++. TheENUM
macro is unnecessary since theenum
prefix for variable declarations is required in C and optional in C++. TheCLASS
macro is required to match the Microsoft C++ ABI -- defined asclass
when in C++ mode andstruct
when in C mode.This PR seeks to solve this by
ENUM
macro, replacing its use with theenum
keyword.CLASS
macro toIOX_C_CLASS
to reduce likelihood of naming conflictssed -i -e 's/\<CLASS\>/IOX_C_CLASS/g' $(find -type f)
CLASS
was in a comment; not referencing the macro.See issue #2327 for a minimal example to reproduce the issue and existing workarounds.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References