search

eclipse-iceoryx / iceoryx

Eclipse iceoryx™ - true zero-copy inter-process-communication
https://iceoryx.io
Apache License 2.0
1.69k stars 396 forks source link

Name clash in RouDi process removeProcess() #271

Closed marthtz closed 4 years ago

marthtz commented 4 years ago

Required information

Operating system: General issue

Compiler version: General issue

Observed result or behaviour: PR #258 cleaned-up some local variable name prefixes. However, that introduced a name clash inside a function rendering a check useless.

Expected result or behaviour: Do a proper check.

Conditions where it occurred / Performed steps: In file /iceoryx_posh/source/roudi/roudi_process.cpp inside bool ProcessManager::removeProcess(...) fix

...
auto name = it->getName();
if (name == name)
...
elBoberido commented 4 years ago

Good catch. I hoped -Wtautological-compare could help here, but it seems it doesn't catch it

marthtz commented 4 years ago

Good catch. I hoped -Wtautological-compare could help here, but it seems it doesn't catch it Yeah, unfortunately it doesn't. Checked it.