search

eclipse-iceoryx / iceoryx

Eclipse iceoryx™ - true zero-copy inter-process-communication
https://iceoryx.io
Apache License 2.0
1.57k stars 373 forks source link

remove blinking warning in Roudi #85

Closed Karsten1987 closed 4 years ago

Karsten1987 commented 4 years ago

The warning of Could not open file '/etc/iceoryx/roudi_config.toml'. is somewhat misleading as it doesn't give the user any more info about what's happening.

Not only does it (annoyingly) blink, the RouDi application runs perfectly fine.

If you look at the two warnings around that, I don't see why this warning has to be red and blinking:

2020-04-13 17:36:36.144 [ Info  ]: No config file provided. Using /etc/iceoryx/roudi_config.toml
Could not open file '/etc/iceoryx/roudi_config.toml'.
2020-04-13 17:36:36.144 [ Info  ]: No config file found at /etc/iceoryx/roudi_config.toml. Falling back to built-in config.
evshary commented 4 years ago

It seems like these info messages can't be hidden by running RouDi command like this RouDi -l off. The reason might be that RouDi tries to get the config before setting log level.

BTW, I'm not sure why some message uses std:cerr instead of iceoryx log function. Is there any reason? (If it's off-topic, I can open another issue to discuss this.)

budrus commented 4 years ago

@evshary good point, I will open the issue. Different logger were used in the past. I guess a cleanup is needed. Sometimes a dependency to a logger in quite low layer modules in the utils was undesired. But there is no clear strategy now

elBoberido commented 4 years ago

yes, this should not blink and also not be printed. It should just print which config is used.

budrus commented 4 years ago

i created a separate issue for the logger topic #130