search

eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
527 stars 26 forks source link

[#231] user defined service properties #232

Closed elfenpiff closed 3 months ago

elfenpiff commented 3 months ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked in the References section
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Closes #231

elfenpiff commented 3 months ago

@jasonashton I think this could be interesting for you.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 82.27848% with 56 lines in your changes missing coverage. Please review.

Project coverage is 79.69%. Comparing base (dcfaf01) to head (74b16c9).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/232/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/232?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #232 +/- ## ========================================== - Coverage 79.71% 79.69% -0.02% ========================================== Files 186 187 +1 Lines 20575 20827 +252 ========================================== + Hits 16401 16599 +198 - Misses 4174 4228 +54 ``` | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/232?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx2/src/service/builder/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/232?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fbuilder%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvYnVpbGRlci9tb2QucnM=) | `88.67% <100.00%> (-1.89%)` | :arrow_down: | | [iceoryx2/src/service/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/232?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvbW9kLnJz) | `71.73% <100.00%> (ø)` | | | [iceoryx2/src/service/service\_name.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/232?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fservice_name.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2Uvc2VydmljZV9uYW1lLnJz) | `75.55% <100.00%> (-2.00%)` | :arrow_down: | | [iceoryx2/src/service/static\_config/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/232?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fstatic_config%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2Uvc3RhdGljX2NvbmZpZy9tb2QucnM=) | `86.41% <100.00%> (+0.89%)` | :arrow_up: | | [iceoryx2/src/service/port\_factory/event.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/232?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fport_factory%2Fevent.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvcG9ydF9mYWN0b3J5L2V2ZW50LnJz) | `87.50% <90.90%> (+1.78%)` | :arrow_up: | | [...ryx2/src/service/port\_factory/publish\_subscribe.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/232?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fport_factory%2Fpublish_subscribe.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvcG9ydF9mYWN0b3J5L3B1Ymxpc2hfc3Vic2NyaWJlLnJz) | `90.32% <92.85%> (+1.03%)` | :arrow_up: | | [iceoryx2-bb/container/src/byte\_string.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/232?src=pr&el=tree&filepath=iceoryx2-bb%2Fcontainer%2Fsrc%2Fbyte_string.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvY29udGFpbmVyL3NyYy9ieXRlX3N0cmluZy5ycw==) | `97.22% <73.07%> (-1.88%)` | :arrow_down: | | [iceoryx2/src/service/builder/publish\_subscribe.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/232?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fbuilder%2Fpublish_subscribe.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvYnVpbGRlci9wdWJsaXNoX3N1YnNjcmliZS5ycw==) | `83.07% <85.89%> (-0.95%)` | :arrow_down: | | [iceoryx2-bb/container/src/vec.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/232?src=pr&el=tree&filepath=iceoryx2-bb%2Fcontainer%2Fsrc%2Fvec.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvY29udGFpbmVyL3NyYy92ZWMucnM=) | `88.28% <75.00%> (-3.07%)` | :arrow_down: | | [iceoryx2/src/service/attribute.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/232?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fattribute.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvYXR0cmlidXRlLnJz) | `84.81% <84.81%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/232?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/232/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)