search

eclipse-kura / kura

Eclipse Kura™ is a versatile framework to supercharge your edge devices, streamlining the process of configuring your gateway, connecting sensors, and IoT devices to seamlessly collect, process, and send data to the cloud.
https://eclipse.dev/kura/
Eclipse Public License 2.0
498 stars 305 forks source link

fix(container.instance): refactored code to remove unreachable code #5212

Closed sfiorani closed 5 months ago

sfiorani commented 5 months ago

This PR fixes a problem in the Container Instance code that led to an unreachable code branch.

When a Container Instance in Disabled state started (startup of Kura or Instance creation) while an other container with same name was already running on the system, the latter was not stopped and deleted: this happened due to an incorrect exit condition of the update method that prevent the correct actions.

Related Issue:

Description of the solution adopted:

Screenshots:

Manual Tests:

Any side note on the changes made:

mattdibi commented 5 months ago

The build succeeds locally but we are facing an issue in the CI connection to Sonar. An issue has been raised few weeks ago to the Eclipse Team: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4422

Merging as-is for now.