search

eclipse-m2e / m2e-core

Eclipse Public License 2.0
113 stars 116 forks source link

Bug 562166 - Importing maven project with AspectJ does not add the aspectj nature/runtime #147

Open marioja opened 3 years ago

marioja commented 3 years ago

https://bugs.eclipse.org/bugs/show_bug.cgi?id=562166

kriegaex commented 3 years ago

Hello. I am a member of the AspectJ development team. Is anybody addressing this issue anytime soon? Is there anything we can do in order to help? While your are fixing this, please also note that currently there are three different group IDs to be supported for artifact aspectj-maven-plugin:

All of these group IDs are already supported by IntelliJ IDEA, but not by Eclipse m2e, even though AspectJ is an Eclipse project. That does not look so good for now. I am trying to support in any way I can with regard to feedback and testing. I probably cannot do much on the Eclipse side, because I mostly use IDEA for development myself. Eclipse I normally only use for AspectJ projects without Maven, but having heard many complaints about AspectJ + Maven no longer working in Eclipse, I want to help to get this issue off the table.

laeubi commented 3 years ago

At least you have the following options to give more priority on this this and get it resolved:

As a starting point, the following instructions might be useful to understand and improve the compatibility of the aspectj-maven plugin and m2eclipse: https://www.eclipse.org/m2e/documentation/m2e-extension-development.html

kriegaex commented 3 years ago
  • Provide a small (executable) reproducer that shows your problem in form of a github project with instructions

OK, I am going to create MCVE projects for you, pairs of pure Eclipse vs. Maven ones with the same code in order to help you resolve this. Comparing pairs of projects should help you to directly compare how Eclipse ends up importing AspectJ Maven projects at present and what I expect to happen instead.

  • Start to provide a patch that fixes the problem

You cannot expect a patch from me. I am already stretched thin, contributing to 4 AspectJ projects (AspectJ Core, AJDT, AspectJ Compiler as a JDT Core fork, AspectJ Maven Plugin) in my sparetime, and I am not even a developer in my daytime job but a freelance consultant (agile coach). Understanding the code of yet another project exceeds my available cycles, sorry.

  • You can sponsor me (or search for someone else with java skills) and offer a funding for this feature

I am not going to sponsor you either, as nobody is sponsoring my OSS contributions either. I am donating lots of my time to OSS projects already. I am not asking for a new feature either. As far as I remember, this used to work in the past, now it no longer does. I am not sure what happened in the meantime. Maybe some API interfaces do not fit together anymore. Maybe someone simply removed AspectJ support from M2E. I thought that as related projects in the Eclipse ecosystem, we could find a collaborative way to get this off the table. AspectJ is not some shady third-party tool we are talking about, but a long-standing Eclipse project.

As a starting point, the following instructions might be useful to understand and improve the compatibility of the aspectj-maven plugin and m2eclipse: https://www.eclipse.org/m2e/documentation/m2e-extension-development.html

image

laeubi commented 3 years ago

You cannot expect a patch from me.[...] Understanding the code of yet another project exceeds my available cycles, sorry.

Same as most of the m2e contributors I think, so no need to be sorry... actually its not specifically you to provide a patch but anyone using AspectJ and m2e and like to help improve something. We are here to hep with questions or problems regarding m2e integration or ways to contribute, e.g. via the m2e dev mailing list.

Maybe some API interfaces do not fit together anymore. Maybe someone simply removed AspectJ support from M2E.

I have searched the m2e source and can't find any hint that there is any support for AspectJ, and actually support for a specific plugins was removed long time ago from m2e in favor of so called m2eclipse connectors. Maybe the AspectJ Development Tools project includes such a connector, at least that would be the most sensible place to have such code from user perspective.

I thought that as related projects in the Eclipse ecosystem, we could find a collaborative way to get this off the table. AspectJ is not some shady third-party tool we are talking about, but a long-standing Eclipse project.

I can't see how m2eclipse and AspectJ are directly related (beside both are Eclipse Projects), don't get me wrong but looking at the history of this problem I think your best bet is to activate someone from your large user-base then who is either able to spend some dev-time on this or paying someone to do so. There hadn't been any activity for this problem for a long time so it seems unlikely to me that any m2e contributors is using AspectJ (or facing the problem) and maybe its rather trivial to fix (e.g. just add the missing nature manually) that no one else was addicted to provide a patch, feedback or further details.

About the link, the page is working for me at the time writing this reply, but it seems eclipse is experiencing heavy outage at different services, so probably try later?

kriegaex commented 3 years ago

It seems like the outage still persists for me, no luck with the link.

Otherwise, thanks for your "help". Now I know that I cannot expect any. Good to know.