search

eclipse-m2e / m2e-core

Eclipse Public License 2.0
113 stars 116 forks source link

[Maven Runtime] Reduce number of manually maintained version and update build-plugins #1811

Closed HannesWell closed 3 months ago

HannesWell commented 3 months ago

  1. Remove manually maintained version of exported packages. The bnd-maven-plugin can derive the version of the org.eclipse.aether* and org.eclipse.sisu* packages perfectly fine based on the OSGi metadata that are embedded in these jars (since some time). Furthermore the version of the exported org.eclipse.sisu* packages has been false before (due to the false version being used manually).

  2. Exclude the dependency to commons-codec explicitly instead of mentioning it as provided to exclude it from the runtime bundle. Excluding it does not require a version to be defined.

github-actions[bot] commented 3 months ago

Test Results

  214 files  ±0    214 suites  ±0   20m 40s :stopwatch: - 1m 34s   665 tests ±0    653 :white_check_mark: ±0  10 :zzz: ±0  2 :x: ±0  1 330 runs  ±0  1 307 :white_check_mark: ±0  20 :zzz: ±0  3 :x: ±0 

For more details on these failures, see this check.

Results for commit 708d5fb0. ± Comparison against base commit a1dad443.

:recycle: This comment has been updated with latest results.

HannesWell commented 3 months ago

Verified that the build results are as expected and org.eclipse.aether* packages are exported with version 1.9.22 while org.eclipse.sisu* packages are exported with version 0.9.0.

Updating the embedded Maven is now even simpler (if no extra adjustments are necessary).