eclipse-m2e / m2e-core

Eclipse Public License 2.0
113 stars 116 forks source link

Revert "Simplify pgp sign" #1858

Closed HannesWell closed 1 month ago

HannesWell commented 1 month ago

This reverts change in pgp-signing done in the commits ca976ab480bab0d31c0af7aa3297fcf99eccb711 and 1dd211b9fba841e0c54744f6a0850bd320ee6a68

github-actions[bot] commented 1 month ago

Test Results

  321 files  ±0    321 suites  ±0   58m 4s :stopwatch: + 8m 15s   678 tests ±0    657 :white_check_mark: +1  18 :zzz: ±0  2 :x: ±0  1 :fire:  - 1  2 034 runs  ±0  1 976 :white_check_mark: ±0  54 :zzz: ±0  3 :x: +1  1 :fire:  - 1 

For more details on these failures and errors, see this check.

Results for commit 16753b4a. ± Comparison against base commit 4e83fd31.

HannesWell commented 1 month ago

The simplification was not impossible but just broken because of a typo, that was fixed in https://github.com/eclipse-m2e/m2e-core/pull/1859. So this is obsolete.