eclipse-m2e / m2e-core

Eclipse Public License 2.0
113 stars 116 forks source link

Provide improved support for long property values #1874

Closed merks closed 1 month ago

merks commented 1 month ago
merks commented 1 month ago

I literally needed to edit a value in some other editor and paste it because it just wasn't possible with the tiny limited-sized dialog:

image

The table layout also improves the use of the existing real estate.

merks commented 1 month ago

A more realistic value that I was editing is like this one:

${file_extract_matching_pattern:${platform-dependencies}/pom.xml,UTF-8,<version.maven.tycho>([^<]+)</version.maven.tycho>,$1,3.0.1}

I'm experimenting with a dynamic variable where I can specify a file to be read with the given encoding, a pattern that's used to find a match in the content, a replacement string used to extract the content, and a default value if the pattern doesn't match. It's quite a bit to specify!

image

github-actions[bot] commented 1 month ago

Test Results

  321 files  ±0    321 suites  ±0   51m 9s :stopwatch: - 4m 16s   678 tests ±0    657 :white_check_mark:  - 1  18 :zzz: ±0  2 :x: +1  1 :fire: ±0  2 034 runs  ±0  1 977 :white_check_mark:  - 1  54 :zzz: ±0  2 :x: +1  1 :fire: ±0 

For more details on these failures and errors, see this check.

Results for commit 9be0f9bf. ± Comparison against base commit 51c902cd.

HannesWell commented 1 month ago

Thank you for this one as well.

If one want's to enhance M2E's launch dialog further I think it would be good if one could edit property keys and values directly in the table without the need of a separate dialog at all.

merks commented 1 month ago

Yes, as well up and down buttons. I know order doesn't matter, but it's still nice to organize.