[lookup] Irregular Lookup class names

[eclipse-ocl-bot]

| --- | --- | | Bugzilla Link | 468156 | | Status | NEW | | Importance | P3 normal | | Reported | May 25, 2015 06:44 EDT | | Modified | Jun 26, 2015 06:28 EDT | | Reporter | Ed Willink |

Description

Lookup.ecore declares an Environment realized by LookupEnvironment and implemented by EnvironmentImpl amongst others.

The missing Environment Java interface is irregular and makes Javadoc unhappy; see below. Javadoc is not the most pressing reason to refactor but is the irregularity really necessary?

[ant] /home/hudson/genie.ocl/.hudson/jobs/ocl-mars-master/workspace/org.eclipse.ocl.git/plugins/org.eclipse.ocl.pivot/emf-gen/org/eclipse/ocl/pivot/internal/lookup/LookupPackage.java:179: warning - Tag @see: can't find getNamedElements() in org.eclipse.ocl.pivot.internal.lookup.LookupEnvironment\ [ant] /home/hudson/genie.ocl/.hudson/jobs/ocl-mars-master/workspace/org.eclipse.ocl.git/plugins/org.eclipse.ocl.pivot/emf-gen/org/eclipse/ocl/pivot/internal/lookup/LookupPackage.java:199: warning - Tag @see: can't find addElement(java.lang.String, org.eclipse.ocl.pivot.NamedElement) in org.eclipse.ocl.pivot.internal.lookup.LookupEnvironment\ [ant] /home/hudson/genie.ocl/.hudson/jobs/ocl-mars-master/workspace/org.eclipse.ocl.git/plugins/org.eclipse.ocl.pivot/emf-gen/org/eclipse/ocl/pivot/internal/lookup/LookupPackage.java:219: warning - Tag @see: can't find addElementsOf(org.eclipse.ocl.pivot.Namespace) in org.eclipse.ocl.pivot.internal.lookup.LookupEnvironment\ [ant] /home/hudson/genie.ocl/.hudson/jobs/ocl-mars-master/workspace/org.eclipse.ocl.git/plugins/org.eclipse.ocl.pivot/emf-gen/org/eclipse/ocl/pivot/internal/lookup/LookupPackage.java:239: warning - Tag @see: can't find nestedEnv() in org.eclipse.ocl.pivot.internal.lookup.LookupEnvironment\ [ant] /home/hudson/genie.ocl/.hudson/jobs/ocl-mars-master/workspace/org.eclipse.ocl.git/plugins/org.eclipse.ocl.pivot/emf-gen/org/eclipse/ocl/pivot/internal/lookup/LookupPackage.java:199: warning - Tag @link: can't find addElement(java.lang.String, org.eclipse.ocl.pivot.NamedElement) in org.eclipse.ocl.pivot.internal.lookup.LookupEnvironment\ [ant] /home/hudson/genie.ocl/.hudson/jobs/ocl-mars-master/workspace/org.eclipse.ocl.git/plugins/org.eclipse.ocl.pivot/emf-gen/org/eclipse/ocl/pivot/internal/lookup/LookupPackage.java:219: warning - Tag @link: can't find addElementsOf(org.eclipse.ocl.pivot.Namespace) in org.eclipse.ocl.pivot.internal.lookup.LookupEnvironment\ [ant] /home/hudson/genie.ocl/.hudson/jobs/ocl-mars-master/workspace/org.eclipse.ocl.git/plugins/org.eclipse.ocl.pivot/emf-gen/org/eclipse/ocl/pivot/internal/lookup/LookupPackage.java:239: warning - Tag @link: can't find nestedEnv() in org.eclipse.ocl.pivot.internal.lookup.LookupEnvironment\ [ant] /home/hudson/genie.ocl/.hudson/jobs/ocl-mars-master/workspace/org.eclipse.ocl.git/plugins/org.eclipse.ocl.pivot/emf-gen/org/eclipse/ocl/pivot/internal/lookup/LookupPackage.java:179: warning - Tag @link: can't find getNamedElements in org.eclipse.ocl.pivot.internal.lookup.LookupEnvironment

[eclipse-ocl-bot]

By Adolfo Sanchez-Barbudo Herrera on Jun 10, 2015 05:41

Hi Ed,

No, I don't it's necessary neither. As I'm doing in the OCL2QVTi test cases examples, I'm in favor of having the interface being generated by EMF rather than referring (via instance class name) an already existent one.

Regards,\ Adolfo.

[eclipse-ocl-bot]

By Adolfo Sanchez-Barbudo Herrera on Jun 24, 2015 13:13

Hi Ed,

asanchez/468156 introduces some changes in the mentioned direction. Please, check that they fix your issue.

I'm interested in having this in master.

Regards,\ Adolfo.

[eclipse-ocl-bot]

By Ed Willink on Jun 26, 2015 06:28

(In reply to Adolfo Sanchez-Barbudo Herrera from comment #2)

I'm interested in having this in master.

Unfortunately the Lookup functionality was not fully removed from the Mars release and so this appears to contribute many API violations. Bug 471114 raised to discuss the more general API compatibility issue.