eclipse-orbit / .eclipsefdn

Repository to host configurations related to the Eclipse Foundation.
https://eclipse-orbit.github.io/.eclipsefdn/
0 stars 2 forks source link

Add the git repository orbit-legacy #7

Closed merks closed 1 year ago

merks commented 1 year ago

https://github.com/eclipse-orbit/orbit/issues/52

github-actions[bot] commented 1 year ago
Diff for e8238bcef8349bcb5ada56324c8c4bed65506e51: ```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-orbit[id=eclipse-orbit] + add repository[name="orbit-legacy"] { + allow_auto_merge = false + allow_forking = true + allow_merge_commit = false + allow_rebase_merge = true + allow_squash_merge = true + allow_update_branch = false + archived = false + default_branch = "main" + delete_branch_on_merge = false + dependabot_alerts_enabled = true + dependabot_security_updates_enabled = false + description = "Third-party libraries not available with source code elsewhere." + gh_pages_build_type = "disabled" + has_discussions = true + has_issues = true + has_projects = true + has_wiki = false + homepage = null + is_template = false + merge_commit_message = "PR_TITLE" + merge_commit_title = "MERGE_MESSAGE" + name = "orbit-legacy" + private = false + secret_scanning = "enabled" + secret_scanning_push_protection = "enabled" + squash_merge_commit_message = "COMMIT_MESSAGES" + squash_merge_commit_title = "COMMIT_OR_PR_TITLE" + template_repository = null + topics = [] + web_commit_signoff_required = false + } Plan: 1 to add, 0 to change, 0 to delete. ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-orbit[id=eclipse-orbit] --- original +++ canonical @@ -50,6 +50,14 @@ has_wiki: false, web_commit_signoff_required: false, }, + orgs.newRepo('orbit-legacy') { + allow_merge_commit: false, + allow_update_branch: false, + description: "Third-party libraries not available with source code elsewhere.", + has_discussions: true, + has_wiki: false, + web_commit_signoff_required: false, + }, orgs.newRepo('orbit-simrel') { allow_merge_commit: false, allow_update_branch: false, @@ -58,14 +66,6 @@ has_wiki: false, web_commit_signoff_required: false, }, - orgs.newRepo('orbit-legacy') { - allow_merge_commit: false, - allow_update_branch: false, - description: "Third-party libraries not available with source code elsewhere.", - has_discussions: true, - has_wiki: false, - web_commit_signoff_required: false, - }, ], } ```
netomi commented 1 year ago

The PR looks good to me. I would just like to clarify how you want PRs approved in this project. @merks you are committer here, @jonahgraham seems to be the only project lead. Let me know if you want project lead approval or if it is sufficient for committers to request stuff.

github-actions[bot] commented 1 year ago
Diff for a0e7547e057bb8644fa19af962e8ce8c7b5e1a5a: ```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-orbit[id=eclipse-orbit] + add repository[name="orbit-legacy"] { + allow_auto_merge = false + allow_forking = true + allow_merge_commit = false + allow_rebase_merge = true + allow_squash_merge = true + allow_update_branch = false + archived = false + default_branch = "main" + delete_branch_on_merge = false + dependabot_alerts_enabled = true + dependabot_security_updates_enabled = false + description = "Third-party libraries not available with source code elsewhere." + gh_pages_build_type = "disabled" + has_discussions = true + has_issues = true + has_projects = true + has_wiki = false + homepage = null + is_template = false + merge_commit_message = "PR_TITLE" + merge_commit_title = "MERGE_MESSAGE" + name = "orbit-legacy" + private = false + secret_scanning = "enabled" + secret_scanning_push_protection = "enabled" + squash_merge_commit_message = "COMMIT_MESSAGES" + squash_merge_commit_title = "COMMIT_OR_PR_TITLE" + template_repository = null + topics = [] + web_commit_signoff_required = false + } Plan: 1 to add, 0 to change, 0 to delete. ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-orbit[id=eclipse-orbit] ```
merks commented 1 year ago

The PR looks good to me. I would just like to clarify how you want PRs approved in this project. @merks you are committer here, @jonahgraham seems to be the only project lead. Let me know if you want project lead approval or if it is sufficient for committers to request stuff.

Probably @jonahgraham should generally approve, but I'm special. 😜

More seriously, note that that he did explicitly approve this change via +1 on this comment:

https://github.com/eclipse-orbit/orbit/issues/52#issuecomment-1659059381

I'm not going to change anything that might be even remotely controversial without agreement. But it's good that you keep an eye out for anything remotely controversial where creating a new repository is definitely on that side of the fence!

netomi commented 1 year ago

Lgtm, ty for the link

netomi commented 1 year ago

change has been applied, repo has been created.

merks commented 1 year ago

I know I've said this several times, but this service is so great!

I've been posting "did you know" tips on the cross projects mailing list. I could mention this cool feature there? You might get a lot of requests to create a .eclipsefdn in that case though. What do you think? Shall I "advertise" this? Is there a good link I could post?

netomi commented 1 year ago

ty for the kind words.

I just worked on something that might be useful for creating PRs. Take a look here:

https://adoptium.github.io/.eclipsefdn/

This will be added for all GitHub organizations, it shows the values inherited from the default configuration when creating specific resources.

btw. it is really good practice, and I hope we can educate every eclipse committer to do like that, to include a link to the discussion / conclusion to create / modify resources with approval of the project. This would make things much more smoother. Sometimes we just wait for stuff to be done before we get approval.

netomi commented 1 year ago

Regarding promoting the tool: please go for it. We would like to migrate all project @ GitHub to their dedicated organization and enable otterdog for them. Here you can see a list of currently enabled projects: https://eclipsefdn.github.io/otterdog-configs/

jonahgraham commented 1 year ago

Probably @jonahgraham should generally approve

@merks has blanket approval from me a PL.

netomi commented 1 year ago

Ack