Closed merks closed 1 year ago
The PR looks good to me. I would just like to clarify how you want PRs approved in this project. @merks you are committer here, @jonahgraham seems to be the only project lead. Let me know if you want project lead approval or if it is sufficient for committers to request stuff.
The PR looks good to me. I would just like to clarify how you want PRs approved in this project. @merks you are committer here, @jonahgraham seems to be the only project lead. Let me know if you want project lead approval or if it is sufficient for committers to request stuff.
Probably @jonahgraham should generally approve, but I'm special. 😜
More seriously, note that that he did explicitly approve this change via +1 on this comment:
https://github.com/eclipse-orbit/orbit/issues/52#issuecomment-1659059381
I'm not going to change anything that might be even remotely controversial without agreement. But it's good that you keep an eye out for anything remotely controversial where creating a new repository is definitely on that side of the fence!
Lgtm, ty for the link
change has been applied, repo has been created.
I know I've said this several times, but this service is so great!
I've been posting "did you know" tips on the cross projects mailing list. I could mention this cool feature there? You might get a lot of requests to create a .eclipsefdn in that case though. What do you think? Shall I "advertise" this? Is there a good link I could post?
ty for the kind words.
I just worked on something that might be useful for creating PRs. Take a look here:
https://adoptium.github.io/.eclipsefdn/
This will be added for all GitHub organizations, it shows the values inherited from the default configuration when creating specific resources.
btw. it is really good practice, and I hope we can educate every eclipse committer to do like that, to include a link to the discussion / conclusion to create / modify resources with approval of the project. This would make things much more smoother. Sometimes we just wait for stuff to be done before we get approval.
Regarding promoting the tool: please go for it. We would like to migrate all project @ GitHub to their dedicated organization and enable otterdog for them. Here you can see a list of currently enabled projects: https://eclipsefdn.github.io/otterdog-configs/
Probably @jonahgraham should generally approve
@merks has blanket approval from me a PL.
Ack
https://github.com/eclipse-orbit/orbit/issues/52