Back navigation in the submission workflow breaks at the review step

jabrah commented 6 years ago

Testing:

Put 10.1039/c7fo01251a in DOI input
Click Next for a while
Once at the Review step, trying the Back button, or clicking on the tab to go back to the Files step throws JS errors:

Uncaught SyntaxError: Unexpected token < in JSON at position 0
    at JSON.parse (<anonymous>)
    at Class.init (workflow-files.js:27)
    at Class.superWrapper [as init] (ember-utils.js:418)
    at new Class (core_object.js:113)
    at Function._ClassMixinProps.create (core_object.js:282)
    at FactoryManager.create (container.js:439)
    at Proxy.create (container.js:197)
    at CurlyComponentManager.create (curly.js:155)
    at runtime.js:1671
    at AppendOpcodes.evaluate (runtime.js:70)

Uncaught Error: a glimmer transaction was begun, but one already exists. You may have a nested transaction
    at debugAssert (util.js:62)
    at Environment.begin (runtime.js:6380)
    at Environment.begin (environment.js:252)
    at InteractiveRenderer._renderRoots (renderer.js:270)
    at InteractiveRenderer._renderRootsTransaction (renderer.js:323)
    at InteractiveRenderer._revalidate (renderer.js:360)
    at invoke (backburner.js:258)
    at Queue.flush (backburner.js:151)
    at DeferredActionQueues.flush (backburner.js:329)
    at Backburner.end (backburner.js:462)

It is worth noting that directly clicking to go back to other tabs, like directly navigating back to the Policies step, for example, worked fine

Rytiggy commented 6 years ago

This should be fixed in the latest version of develop, it was fixed in this PR https://github.com/OA-PASS/pass-ember/pull/416/files

htpvu commented 6 years ago

rev. dc62eb14 - verified

eclipse-pass / pass-ui

Back navigation in the submission workflow breaks at the review step #408