Incorrect size of org.eclipse.help.ui/icons/obj16/container_obj.png

eclipse-platform / eclipse.platform.images

Eclipse Public License 2.0

11 stars 19 forks source link

Incorrect size of org.eclipse.help.ui/icons/obj16/container_obj.png #94

Open 2wendex2 opened 3 days ago

2wendex2 commented 3 days ago

Description of the bug Icon org.eclipse.help.ui/icons/obj16/container_obj.png has 14x13 size but model object icon should be have 16x16 size. See https://www.eclipse.org/articles/Article-UI-Guidelines/Contents.html#IconSpecsSize_VDG

Because of this that icon looks stretched in the Help view.

Possible fixes Replace current icon with an icon with size 16x16. Attached a possible new icon: container_obj

akurtakov commented 3 days ago

@BeckerWdf Would you be able to look into that one?

BeckerWdf commented 3 days ago

@BeckerWdf Would you be able to look into that one?

Sure

BeckerWdf commented 3 days ago

Icon org.eclipse.help.ui/icons/obj16/topic_small.png has 14x13 size but model object icon should be have 16x16 size

I don't see this. See:

Where do you see the icons stretched? Can you mark it in the screenshot?

BeckerWdf commented 3 days ago

Where do you see the icons stretched? Can you mark it in the screenshot?

Do you mean this one and does this look better to you?

2wendex2 commented 3 days ago

@BeckerWdf I made a mistake. I wanted to say about org.eclipse.help.ui/icons/obj16/container_obj.png

BeckerWdf commented 3 days ago

@BeckerWdf I made a mistake. I wanted to say about org.eclipse.help.ui/icons/obj16/container_obj.png

Ah yes I see. I can fix that. But independent from that issue. What do you think about the drawing in side making topic_small a bit bigger (using topic.png) as shown in my screenshot?

2wendex2 commented 3 days ago

Ah yes I see. I can fix that. But independent from that issue. What do you think about the drawing in side making topic_small a bit bigger (using topic.png) as shown in my screenshot?

I don't think this is a very good idea. I have already tried to resize the icon without stretching or changing it and it looks good. My icon with changed size: container_obj Table of contents after changing size of icon:

BeckerWdf commented 2 days ago

How about this:

Does it look better?

2wendex2 commented 2 days ago

Does it look better?

No, obj_container icon and obj_container with overlay icon should have the same size. How did you do two variant? Redrawn both icons?

2wendex2 commented 2 days ago

Try to just replace obj_container icon on this container_obj and look

BeckerWdf commented 2 days ago

Does it look better?

No, obj_container icon and obj_container with overlay icon should have the same size. How did you do two variant? Redrawn both icons?

I have fix the SVG of obj_contain icon. With "obj_contain with overlay" you mean the once e.g. in front of "Basic tutorial"? This is created by combining obj_contain.png with the overlay icon doc_co.png like this:

        ImageDescriptor base = HelpUIResources
                .getImageDescriptor(IHelpUIConstants.IMAGE_CONTAINER);
        ImageDescriptor ovr = HelpUIResources
                .getImageDescriptor(IHelpUIConstants.IMAGE_DOC_OVR);
        ImageDescriptor desc = new OverlayIcon(base,
                new ImageDescriptor[][] { { ovr } });
        containerWithTopicImage = desc.createImage();

So shouldn't they have the same size then?

BeckerWdf commented 2 days ago

Try to just replace obj_container icon on this and look

I need a file not an inline attachment...

BeckerWdf commented 2 days ago

Sorry I made an error: This is the correct before and after imag:

2wendex2 commented 2 days ago

Yes, now it looks right! I also think it would be better if move this icon down for one pixel

2wendex2 commented 2 days ago

This is created by combining obj_contain.png with the overlay icon doc_co.png like this:

Yes, I know. I think now it would be better if we move overlay icon right for one pixel (similarly) or move obj_container one pixel left