search

eclipse-platform / eclipse.platform

https://eclipse.dev/eclipse/
Eclipse Public License 2.0
84 stars 113 forks source link

ContentTypeCatalog#removeContentType: add missing synchronize #1530

Closed jukzi closed 2 months ago

jukzi commented 2 months ago

For concurrent access to ContentTypeCatalog.contentTypes

Found by code inspection - i wondered why internalFindContentTypesSorted() is synchronized.

image (during file search)

github-actions[bot] commented 2 months ago

Test Results

 1 734 files  ±0   1 734 suites  ±0   1h 29m 12s :stopwatch: + 5m 2s  3 979 tests ±0   3 956 :white_check_mark: ±0   22 :zzz: ±0  1 :x: ±0  12 534 runs  ±0  12 367 :white_check_mark: ±0  164 :zzz: ±0  3 :x: ±0 

For more details on these failures, see this check.

Results for commit 807ee8e4. ± Comparison against base commit 2fb8958c.

:recycle: This comment has been updated with latest results.

jukzi commented 2 months ago

ignoring unrelated failing test "TocLinkChecker.testPdeUserGenerated" - already failed in IBuild