Breakpoint Enable All feature

eclipse-platform / eclipse.platform

https://eclipse.dev/eclipse/

Eclipse Public License 2.0

84 stars 113 forks source link

Breakpoint Enable All feature #1533

Closed SougandhS closed 2 months ago

SougandhS commented 2 months ago

Changes for Enable All breakpoints in breakpoints view similar to Disable All breakpoints we already have. Fix for - https://github.com/eclipse-platform/eclipse.platform/issues/1532 referring - https://github.com/eclipse-jdt/eclipse.jdt.debug/issues/198

SougandhS commented 2 months ago

@jukzi could you please review this PR ?

jukzi commented 2 months ago

please post a screenshot - what is that "Do not ask me again" used for?

SougandhS commented 2 months ago

please post a screenshot - what is that "Do not ask me again" used for? On clicking Enable All option a confirmation window is opened. If we tick Do not ask me again then next time onwards confirmation pop is not shown and all breakpoints are enabled.

jukzi commented 2 months ago

can you please change the order of the Actions so that Both "enable" are next to each other

SougandhS commented 2 months ago

can you please change the order of the Actions so that Both "enable" are next to each other

Sure Jukzi, made the changes

github-actions[bot] commented 2 months ago

Test Results

1 734 files ±0 1 734 suites ±0 1h 25m 35s :stopwatch: - 6m 19s 3 979 tests ±0 3 957 :white_check_mark: ±0 22 :zzz: ±0 0 :x: ±0 12 534 runs ±0 12 370 :white_check_mark: ±0 164 :zzz: ±0 0 :x: ±0

Results for commit 0e4bc487. ± Comparison against base commit 75d509d0.

SougandhS commented 2 months ago

Thank you Jukzi.