search

eclipse-platform / eclipse.platform

https://eclipse.dev/eclipse/
Eclipse Public License 2.0
84 stars 113 forks source link

Fix for RejectedExecutionException during delete operations #1593

Closed iloveeclipse closed 1 month ago

iloveeclipse commented 1 month ago

If the tasks scheduled by ForkJoinPool are all busy and new task is added, the pool would throw RejectedExecutionException if the "saturate" Predicate is not specified.

To avoid that, supply Predicate that is always true - with that, no exception will be thrown on busy pool and we would not reject new delete operations.

Fixes https://github.com/eclipse-platform/eclipse.platform/issues/1592

github-actions[bot] commented 1 month ago

Test Results

 1 758 files  ±0   1 758 suites  ±0   1h 26m 53s :stopwatch: - 3m 33s  4 170 tests ±0   4 148 :white_check_mark: ±0   22 :zzz: ±0  0 :x: ±0  13 107 runs  ±0  12 943 :white_check_mark: ±0  164 :zzz: ±0  0 :x: ±0 

Results for commit f99df038. ± Comparison against base commit 31d84d12.

iloveeclipse commented 1 month ago

@akurtakov : I plan to trigger new IBuild just to make sure this fix (or original issue) doesn't have any relationship to OOM's in https://github.com/eclipse-platform/eclipse.platform.ui/issues/2432 Any objections ?

akurtakov commented 1 month ago

Go for it.

iloveeclipse commented 1 month ago

https://ci.eclipse.org/releng/job/Builds/job/I-build-4.34/93/