search

eclipse-platform / eclipse.platform

https://eclipse.dev/eclipse/
Eclipse Public License 2.0
84 stars 113 forks source link

remove org.eclipse.ant.internal.core.AntSecurityManager.getInCheck() ? #1601

Closed jukzi closed 3 weeks ago

jukzi commented 3 weeks ago

method has been removed in JDK 10

java.lang.NoSuchMethodException: java.lang.SecurityManager.getInCheck()
    at java.base/java.lang.Class.getMethod(Class.java:2227)
    at org.eclipse.ant.internal.core.AntSecurityManager.getInCheck(AntSecurityManager.java:399)
    at org.eclipse.ant.tests.core.tests.AntSecurityManagerTest.test_getInCheck(AntSecurityManagerTest.java:16)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.base/java.lang.reflect.Method.invoke(Method.java:568)
    at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:767)
    at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)

https://download.eclipse.org/eclipse/downloads/drops4/I20241028-0700/testresults/ep434I-unit-win32-java17_win32.win32.x86_64_17/org.eclipse.ant.tests.core.AutomatedAntSuite.txt

akurtakov commented 3 weeks ago

Sounds like the right thing to do . All the other removed in Java 10 should reb removed too IMO.

akurtakov commented 3 weeks ago

@jukzi Thanks for spotting that. IMO things like that are exactly what prevents us from having good overlook of the test suites as there are way too much useless things that accumulated over the years that need pruning very badly.