search

eclipse-platform / eclipse.platform

https://eclipse.dev/eclipse/
Eclipse Public License 2.0
84 stars 113 forks source link

show diff in "replace with local history" dialog on selection change #1625

Open tobiasmelcher opened 2 days ago

tobiasmelcher commented 2 days ago

The "Replace With" -> "Local History ..." option in the source editor context menu launches a dialog that allows users to revert to a previous version. Initially, this dialog displays a list of all available revisions:

replace_with_local_history

Previously, selecting an entry from the revision list did not trigger any action. Users had to double-click to view the differences.

This pull request enhances the behavior by displaying the differences upon a single click/selection.

eclipse-platform-bot commented 2 days ago

This pull request changes some projects for the first time in this development cycle. Therefore the following files need a version increment:

team/bundles/org.eclipse.team.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch ``` From 5c2ffcd7fa527d53d879be4e306b9c08b4086407 Mon Sep 17 00:00:00 2001 From: Eclipse Platform Bot Date: Wed, 20 Nov 2024 12:58:35 +0000 Subject: [PATCH] Version bump(s) for 4.34 stream diff --git a/team/bundles/org.eclipse.team.ui/META-INF/MANIFEST.MF b/team/bundles/org.eclipse.team.ui/META-INF/MANIFEST.MF index 6216164598..69f24141ff 100644 --- a/team/bundles/org.eclipse.team.ui/META-INF/MANIFEST.MF +++ b/team/bundles/org.eclipse.team.ui/META-INF/MANIFEST.MF @@ -2,7 +2,7 @@ Manifest-Version: 1.0 Bundle-ManifestVersion: 2 Bundle-Name: %pluginName Bundle-SymbolicName: org.eclipse.team.ui; singleton:=true -Bundle-Version: 3.10.500.qualifier +Bundle-Version: 3.10.600.qualifier Bundle-Activator: org.eclipse.team.internal.ui.TeamUIPlugin Bundle-Vendor: %providerName Bundle-Localization: plugin -- 2.47.0 ```

Further information are available in Common Build Issues - Missing version increments.

github-actions[bot] commented 2 days ago

Test Results

 1 755 files  ±0   1 755 suites  ±0   1h 34m 12s ⏱️ - 4m 43s  4 170 tests ±0   4 148 ✅ ±0   22 💤 ±0  0 ❌ ±0  13 107 runs  ±0  12 943 ✅ ±0  164 💤 ±0  0 ❌ ±0 

Results for commit 925d2fd1. ± Comparison against base commit 6dd67323.

:recycle: This comment has been updated with latest results.

tobiasmelcher commented 2 days ago

Issue was detected in an internal UX review. UX experts were asking us why the UI is not updated when an entry in the history list is selected. Question is absolutely valid from my point of view.