eclipse-platform / www.eclipse.org-eclipse

3 stars 46 forks source link

Complete N&N for 4.33 #211

Closed merks closed 3 months ago

merks commented 3 months ago

New and noteworthy affects all projects:

https://eclipse.dev/eclipse/news/4.33/

though the content is maintained here in one project:

https://github.com/eclipse-platform/www.eclipse.org-eclipse/tree/master/news/4.33

In any case, before the release, I've been cleaning up empty sections, e.g.,

https://eclipse.dev/eclipse/news/4.33/jdt.php https://eclipse.dev/eclipse/news/4.33/pde.php

and removing references to entirely empty pages, e.g.,

https://eclipse.dev/eclipse/news/4.33/platform_isv.php

But then I discovered that the content is copied to doc plugins at some point, which must be very soon now to be in RC2, e.g.,

image

So are we really done with the N&N for this cycle so that I can do the cleanup? Is there nothing else interesting that was done in JDT? Are there really no new APIs in the Platform or Equinox?

akurtakov commented 3 months ago

Please don't wait for adding N&N items at end of cycle but rather write it down as soon as it's in I-build. Also don't hesitate to add N&N for smaller items as this is what users read/see for releases.

BeckerWdf commented 3 months ago

o are we really done with the N&N for this cycle so that I can do the cleanup?

@Christopher-Hermann would like to add an entry for the "Sticky Scrolling" feature. Is that still possible? I also wondering because of https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/pull/2248.

akurtakov commented 3 months ago

@BeckerWdf you have by EOD tomorrow, waiting for last minute is not nice from releng POV as even fixing a typo will require respins!

merks commented 3 months ago

Yes, this copying process is a problem because I don't know when exactly it happens. Somehow the cleanup of empty sections/pages needs to be synced and finished before the copying process or along with the copying process.

Also all the developers need to be aware that at some point there are two copies of everything, hence @akurtakov comment about doing this as soon as it's new.

BeckerWdf commented 3 months ago

@BeckerWdf you have by EOD tomorrow, waiting for last minute is not nice from releng POV as even fixing a typo will require respins!

Yes I know. This wasn't planned to be so late.

akurtakov commented 3 months ago

IMO it's time to stop copying N&N in docs bundles and point to online content instead.

Christopher-Hermann commented 3 months ago

I added the sticky scrolling feature to the N&N via #212. Sorry for the late input, I didn't had time the last weeks due to vacation time.

iloveeclipse commented 3 months ago

I'm still on vacation, I believe we miss the entry about dropping support for old Java targets in compiler. Would be good to have some note in N&N. I will be able to do this tomorrow afternoon (I hope). If someone could do it before, please do. @trancexpress ?

merks commented 3 months ago

Oh dear, yes that is of fundamental interest/import!

trancexpress commented 3 months ago

I'm still on vacation, I believe we miss the entry about dropping support for old Java targets in compiler. Would be good to have some note in N&N. I will be able to do this tomorrow afternoon (I hope). If someone could do it before, please do. @trancexpress ?

@iloveeclipse is this enough?

image

merks commented 3 months ago

Small nits.

I.e. is always followed by a comma, i.e., i.e.,.

The last sentence should probably mention javac rather than just mention Java 21, e.g., this is equivalent to Java 21's javac only supporting...

In any case, thanks for the rapid response. 🚀 ❤️

HannesWell commented 3 months ago

IMO it's time to stop copying N&N in docs bundles and point to online content instead.

In my opinion the opposite is also an option worth to consider: Maintain the news in the doc-bundles at the corresponding repositories (using Markdown syntax 😃) and automatically copy the content to the website on a change. This would avoid the need to contribute to (and point newcomers) to yet another repository.

Please don't wait for adding N&N items at end of cycle but rather write it down as soon as it's in I-build. Also don't hesitate to add N&N for smaller items as this is what users read/see for releases.

If the doc-bundle in the PDE/JDT/Platform repo is the master, one could add the N&N entry with the feature in one commit (if it's in the same repo).

HannesWell commented 3 months ago

So are we really done with the N&N for this cycle so that I can do the cleanup? Is there nothing else interesting that was done in JDT? Are there really no new APIs in the Platform or Equinox?

From the top of my head I remember the new APIs in IFile from @jukzi in

etc. IMO it would be good to add an entry for them.

merks commented 3 months ago

The SWT APIs section is empty:

https://github.com/eclipse-platform/www.eclipse.org-eclipse/blob/326fcd5cda6e92ab49f44f267b196a8936d90a6c/news/4.33/platform_isv.html#L61-L64

But my search indicates that's maybe an oversight.

image

@laeubi

Surely given the time we spent discussing and tuning BusyIndicator.showWhile(Future<?>) it calls for a note.

@HeikoKlare

The display changes aren't worth calling attention to at this time?

HeikoKlare commented 3 months ago

@merks thank you for pointing to those changes.

The display changes aren't worth calling attention to at this time?

Exactly. These changes are for enabling/evaluating the multi-monitor HiDPI support (rescaling at runtime) on Windows. However, the feature is still work-in-progress, so I would prefer to not emphasize these API extensions now. We expect the feature to become ready for production during 2024-12 development, which is why I propose to promote the according API for that release. One might argue that the API was technically introduced with 2024-09, so promoting it for 2024-12 is kind of "inconsistent", but I do not see a benefit in promoting a kind of experimental API now while it becomes really useful with the next release (and will thus worth to be mentioned in the N&N for 2024-12).

merks commented 3 months ago

Folks added a bunch of N&N entries and finally now I've commented out empty sections.