search

eclipse-rdf4j / rdf4j

Eclipse RDF4J: scalable RDF for Java
https://rdf4j.org/
BSD 3-Clause "New" or "Revised" License
360 stars 163 forks source link

Replace WireMock with MockServer #4431

Closed erikgb closed 1 year ago

erikgb commented 1 year ago 
          Fwiw we use WireMock in a very limited part of the project only and despite me introducing it, I've never really been a massive fan of it. If we can rework those tests to use something else I don't mind just ripping WireMock out (not sure if I'm opening a can of worms here though)

On Tue, 14 Feb 2023, at 04:43, Erik Godding Boye wrote:

This should probably be targeted at develop.

Probably yes, but I suspect we cannot upgrade to Jakarta EE 8 because of no WireMock version supporting that. Seems like they went straight for Jakarta EE 9.

Originally posted by @abrokenjester in https://github.com/eclipse/rdf4j/issues/4397#issuecomment-1430503422

erikgb commented 1 year ago

I'll vote for MockServer, as that seems like a smooth migration path. POC PR: https://github.com/eclipse/rdf4j/pull/4429

MockServer publishes artifacts without transitive dependencies and uses Netty - which does not have any dependencies on Java/Jakarta EE - which I consider a big PLUS.

abrokenjester commented 1 year ago

@erikgb looks good to me! MockServer seems a solid well-maintained project, license-wise it's all good (Apache 2 license). Your POC PR looks clean enough to me, let's just go for it!

erikgb commented 1 year ago

@erikgb looks good to me! MockServer seems a solid well-maintained project, license-wise it's all good (Apache 2 license). Your POC PR looks clean enough to me, let's just go for it!

@abrokenjester I'm on it. Please assign the issue to me.

erikgb commented 1 year ago

@abrokenjester https://github.com/eclipse/rdf4j/pull/4439 is ready for review.