search

eclipse-rdf4j / rdf4j

Eclipse RDF4J: scalable RDF for Java
https://rdf4j.org/
BSD 3-Clause "New" or "Revised" License
360 stars 163 forks source link

Workbench: No multipart config for servlet on Jetty 12 #5092

Open barthanssens opened 2 months ago

barthanssens commented 2 months ago

Current Behavior

When deploying the workbench on Jetty 12, the workbench loads just fine, and a new store can be created.

However, trying to add a statement via the webinterface to this newly created store results in a "No multipart config for servlet" error (even with ee8-annotations module enabled)

Expected Behavior

The statement should be added

Steps To Reproduce

No response

Version

5.0.0

Are you interested in contributing a solution yourself?

Perhaps?

Anything else?

java.lang.IllegalStateException: No multipart config for servlet
    at org.eclipse.jetty.ee8.nested.Request.getParts(Request.java:1700)
    at org.eclipse.jetty.ee8.nested.Request.getParts(Request.java:1684)
    at javax.servlet.http.HttpServletRequestWrapper.getParts(HttpServletRequestWrapper.java:317)
    at javax.servlet.http.HttpServletRequestWrapper.getParts(HttpServletRequestWrapper.java:317)
    at javax.servlet.http.HttpServletRequestWrapper.getParts(HttpServletRequestWrapper.java:317)
    at javax.servlet.http.HttpServletRequestWrapper.getParts(HttpServletRequestWrapper.java:317)
    at org.eclipse.rdf4j.workbench.util.WorkbenchRequest.getMultipartParameterMap(WorkbenchRequest.java:284)
    at org.eclipse.rdf4j.workbench.util.WorkbenchRequest.<init>(WorkbenchRequest.java:74)
    at org.eclipse.rdf4j.workbench.base.TransformationServlet.service(TransformationServlet.java:94)
    at org.eclipse.rdf4j.workbench.base.AbstractServlet.service(AbstractServlet.java:129)
    at org.eclipse.rdf4j.workbench.proxy.ProxyRepositoryServlet.service(ProxyRepositoryServlet.java:100)
    at org.eclipse.rdf4j.workbench.proxy.WorkbenchServlet.service(WorkbenchServlet.java:215)
    at org.eclipse.rdf4j.workbench.proxy.WorkbenchServlet.handleRequest(WorkbenchServlet.java:137)
    at org.eclipse.rdf4j.workbench.proxy.WorkbenchServlet.service(WorkbenchServlet.java:112)
    at org.eclipse.rdf4j.workbench.proxy.WorkbenchGateway.service(WorkbenchGateway.java:119)
    at org.eclipse.rdf4j.workbench.base.AbstractServlet.service(AbstractServlet.java:129)
    at org.eclipse.jetty.ee8.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1151)
    at org.eclipse.jetty.ee8.servlet.ServletHolder.handle(ServletHolder.java:640)
    at org.eclipse.jetty.ee8.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1374)
    at org.eclipse.rdf4j.workbench.proxy.CacheFilter.doFilter(CacheFilter.java:64)
    at org.eclipse.jetty.ee8.servlet.FilterHolder.doFilter(FilterHolder.java:171)
    at org.eclipse.jetty.ee8.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1348)
    at org.eclipse.rdf4j.workbench.proxy.CookieCacheControlFilter.doFilter(CookieCacheControlFilter.java:56)
    at org.eclipse.jetty.ee8.servlet.FilterHolder.doFilter(FilterHolder.java:177)
    at org.eclipse.jetty.ee8.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1348)
    at org.eclipse.jetty.ee8.servlet.ServletHandler.doHandle(ServletHandler.java:454)
    at org.eclipse.jetty.ee8.nested.ScopedHandler.handle(ScopedHandler.java:119)
    at org.eclipse.jetty.ee8.security.SecurityHandler.handle(SecurityHandler.java:497)
    at org.eclipse.jetty.ee8.nested.HandlerWrapper.handle(HandlerWrapper.java:108)
    at org.eclipse.jetty.ee8.nested.ScopedHandler.nextHandle(ScopedHandler.java:183)
    at org.eclipse.jetty.ee8.nested.SessionHandler.doHandle(SessionHandler.java:514)
    at org.eclipse.jetty.ee8.nested.ScopedHandler.nextHandle(ScopedHandler.java:181)
    at org.eclipse.jetty.ee8.nested.ContextHandler.doHandle(ContextHandler.java:878)
    at org.eclipse.jetty.ee8.nested.ScopedHandler.nextScope(ScopedHandler.java:152)
    at org.eclipse.jetty.ee8.servlet.ServletHandler.doScope(ServletHandler.java:423)
    at org.eclipse.jetty.ee8.nested.ScopedHandler.nextScope(ScopedHandler.java:150)
    at org.eclipse.jetty.ee8.nested.SessionHandler.doScope(SessionHandler.java:498)
    at org.eclipse.jetty.ee8.nested.ScopedHandler.nextScope(ScopedHandler.java:150)
    at org.eclipse.jetty.ee8.nested.ContextHandler.doScope(ContextHandler.java:823)
    at org.eclipse.jetty.ee8.nested.ScopedHandler.handle(ScopedHandler.java:117)
    at org.eclipse.jetty.ee8.nested.ContextHandler.handle(ContextHandler.java:1421)
    at org.eclipse.jetty.ee8.nested.HttpChannel$RequestDispatchable.dispatch(HttpChannel.java:1294)
    at org.eclipse.jetty.ee8.nested.HttpChannel.dispatch(HttpChannel.java:624)
    at org.eclipse.jetty.ee8.nested.HttpChannel.handle(HttpChannel.java:456)
    at org.eclipse.jetty.ee8.nested.ContextHandler$CoreContextHandler$CoreToNestedHandler.handle(ContextHandler.java:2350)
    at org.eclipse.jetty.server.handler.ContextHandler.handle(ContextHandler.java:858)
    at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:181)
    at org.eclipse.jetty.server.Handler$Wrapper.handle(Handler.java:740)
    at org.eclipse.jetty.server.handler.GracefulHandler.handle(GracefulHandler.java:101)
    at org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:597)
    at org.eclipse.jetty.server.Server.handle(Server.java:181)
    at org.eclipse.jetty.server.internal.HttpChannelState$HandlerInvoker.run(HttpChannelState.java:648)
    at org.eclipse.jetty.server.internal.HttpConnection.onFillable(HttpConnection.java:403)
    at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:322)
    at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:99)
    at org.eclipse.jetty.io.SelectableChannelEndPoint$1.run(SelectableChannelEndPoint.java:53)
    at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.runTask(AdaptiveExecutionStrategy.java:478)
    at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.consumeTask(AdaptiveExecutionStrategy.java:441)
    at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.tryProduce(AdaptiveExecutionStrategy.java:293)
    at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.run(AdaptiveExecutionStrategy.java:201)
    at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:311)
    at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:979)
    at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.doRunJob(QueuedThreadPool.java:1209)
    at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1164)
    at java.base/java.lang.Thread.run(Unknown Source)
hmottestad commented 2 months ago

Could be that we need to upgrade to servlet 4:

https://github.com/eclipse-rdf4j/rdf4j/blob/2a998c3f30ec177ecbd3d5bbb4ad209f0c83e2a9/pom.xml#L377

barthanssens commented 2 months ago

Worth the try, adding multipart-config to various Servlets (via jetty's web.xml override mechanism) didn't make a difference.

barthanssens commented 1 month ago

Upgrading to Servlet API 4 didn't seem to change anything, so back to checking / adding annotations ...

barthanssens commented 1 month ago

Could be due to the cache filters (Tomcat does not really mind, or at least not anymore)