Remove the `required_approving_review_count`

[pcdavid]

We sometimes need to push changes quickly without waiting for a review from another commiter.

We trust our commiters not to abuse this power.

[github-actions[bot]]

Diff for 001c967e20982fba8ba08ac1b82d41d1df8c3087:

```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-sirius[id=eclipse-sirius] there have been 2 validation infos, enable verbose output with '-v' to to display them. ! branch_protection_rule[pattern="master", repository="sirius-desktop"] { ! required_approving_review_count = "1" -> "2" } Plan: 0 to add, 1 to change, 0 to delete. ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-sirius[id=eclipse-sirius] --- original +++ canonical @@ -63,7 +63,6 @@ branch_protection_rules: [ orgs.newBranchProtectionRule('master') { required_approving_review_count: 1, - required_status_checks: [], requires_linear_history: true, requires_strict_status_checks: true, }, @@ -115,7 +114,6 @@ branch_protection_rules: [ orgs.newBranchProtectionRule('master') { required_approving_review_count: 1, - required_status_checks: [], requires_linear_history: true, requires_strict_status_checks: true, }, ```

[github-actions[bot]]

Diff for 5d9b9bbb9cd09b7c9672806498a71fbf1047f563:

```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-sirius[id=eclipse-sirius] there have been 2 validation infos, enable verbose output with '-v' to to display them. ! branch_protection_rule[pattern="master", repository="sirius-desktop"] { ! required_approving_review_count = "1" -> "0" } Plan: 0 to add, 1 to change, 0 to delete. ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-sirius[id=eclipse-sirius] --- original +++ canonical @@ -63,7 +63,6 @@ branch_protection_rules: [ orgs.newBranchProtectionRule('master') { required_approving_review_count: 1, - required_status_checks: [], requires_linear_history: true, requires_strict_status_checks: true, }, @@ -116,7 +115,6 @@ branch_protection_rules: [ orgs.newBranchProtectionRule('master') { required_approving_review_count: 1, - required_status_checks: [], requires_linear_history: true, requires_strict_status_checks: true, }, ```

[netomi]

@pcdavid when trying to apply the setting I noticed some other changes that would be applied

I digged into why the sirius-desktop repo has no projects enabled and I have seen the following in the audit log:

can you confirm that you disabled projects and wiki for this repo and that this change should stay like that? In the future, changes like that should be done via the configuration hosted here, there are organization settings has_projects and has_wiki.

[netomi]

The change has been applied. I also updated the configuration to reflect that has_projects and has_wiki has been disabled for the sirius-desktop repo.

[pcdavid]

can you confirm that you disabled projects and wiki for this repo and that this change should stay like that? In the future, changes like that should be done via the configuration hosted here, there are organization settings has_projects and has_wiki.

Yes, that was me. Sorry about that. I'll be more careful.