eclipse-sirius / .eclipsefdn

Repository to host configurations related to the Eclipse Foundation.
https://eclipse-sirius.github.io/.eclipsefdn/
0 stars 2 forks source link

Remove the old sirius-web repo #3

Closed pcdavid closed 1 year ago

pcdavid commented 1 year ago

We currently have two separate GitHub repos for the web version of Eclipse Sirius https://github.com/eclipse-sirius/sirius-components and https://github.com/eclipse-sirius/sirius-web. Initialy the split was to separate the "framework" part (sirius-components) from the "default application" part (sirius-web).

In practice this has caused more overhead than it's worth, and in the last few months we have re-integrated the code for the "default application" in sirius-components where 99% of the code lives. sirius-components is now self-contained and is where the actual development occur.

We would like to:

We split this in two separate steps as we will reuse the sirius-web name, and I don't think the two operations can be described in a single Otterdog configuration change.

github-actions[bot] commented 1 year ago
Diff for c0d9c7c2efb810a29adfffcef894255f30ac3012: ```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-sirius[id=eclipse-sirius] there have been 2 validation infos, enable verbose output with '-v' to to display them. - remove repository[name="sirius-web"] { - allow_auto_merge = false - allow_forking = true - allow_merge_commit = true - allow_rebase_merge = true - allow_squash_merge = true - allow_update_branch = false - archived = false - default_branch = "master" - delete_branch_on_merge = false - dependabot_alerts_enabled = false - dependabot_security_updates_enabled = false - description = "Sirius Web: cloud-based graphical modelers for dedicated DSLs (sample application)" - gh_pages_build_type = "disabled" - has_discussions = false - has_issues = true - has_projects = true - has_wiki = true - homepage = "https://www.eclipse.org/sirius/sirius-web.html" - is_template = false - merge_commit_message = "PR_TITLE" - merge_commit_title = "MERGE_MESSAGE" - name = "sirius-web" - private = false - secret_scanning = "disabled" - secret_scanning_push_protection = "disabled" - squash_merge_commit_message = "COMMIT_MESSAGES" - squash_merge_commit_title = "COMMIT_OR_PR_TITLE" - template_repository = null - topics = [] - web_commit_signoff_required = false - } Plan: 0 to add, 0 to change, 1 to delete. ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-sirius[id=eclipse-sirius] --- original +++ canonical @@ -9,6 +9,7 @@ branch_protection_rules: [ orgs.newBranchProtectionRule('master') { required_approving_review_count: 1 + required_status_checks: [] requires_linear_history: true requires_strict_status_checks: true } ```
netomi commented 1 year ago

Makes sense, however, may I suggest to rename and archive the existing sirius-web repo instead of deleting it right away?

pcdavid commented 1 year ago

If we rename it, it means creating an alias for e.g. sirius-web-archive to sirius-web. But then won't we need a new intermediate step to remove the alias before reusing that name (sirius-web) in the second renaming?

  1. sirius-web-archive { aliases: [sirius-web] }
  2. sirius-web-archive { }
  3. sirius-web { aliases: [sirius-components] }
pcdavid commented 1 year ago

Not sure it's worth the hassle given the contents. If that's OK with you, please proceed and delete. We still have clones of the actual code if we ever want to re-import its history.

netomi commented 1 year ago

If we rename it, it means creating an alias for e.g. sirius-web-archive to sirius-web. But then won't we need a new intermediate step to remove the alias before reusing that name (sirius-web) in the second renaming?

1. `sirius-web-archive { aliases: [sirius-web] }`

2. `sirius-web-archive { }`

3. `sirius-web { aliases: [sirius-components] }`

removing the alias for sirius-web-archive could be done together with the last step, so 2 steps would be required. But tbh we also never did this before. GitHub has a feature to recover deleted repos, though I do not know if this works when the name is already taken by another repo in the meantime.

pcdavid commented 1 year ago

There's really nothing worth keeping in that repo that has not been fully migrated to sirius-components already. I've made a fork at https://github.com/pcdavid/sirius-web-archive if we really wanted to re-import the history into a new repo afterwards, but I'd rather we proceed with the deletion for the moment so that the switch/renaming can be done soon.

netomi commented 1 year ago

repo has been deleted.

pcdavid commented 1 year ago

Thanks! See https://github.com/eclipse-sirius/.eclipsefdn/pull/4 for the follow-up.