eclipse-thingweb / .eclipsefdn

Repository to host configurations related to the Eclipse Foundation.
https://eclipse-thingweb.github.io/.eclipsefdn/
1 stars 3 forks source link

Adding .github repository #3

Closed egekorkan closed 1 year ago

egekorkan commented 1 year ago

As we have spoken on our friday calls, we decided to have a repository for project-level "stuff", which are:

egekorkan commented 1 year ago

@netomi let's wait for @relu91 and @danielpeintner to have a look first before merging

github-actions[bot] commented 1 year ago
Diff for 2631a80a9ca74e238de4f11a42f2e8607b59cde5: ```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-thingweb[id=eclipse-thingweb] there have been 4 validation infos, enable verbose output with '-v' to to display them. + add repository[name=".github"] { + allow_auto_merge = false + allow_forking = true + allow_merge_commit = true + allow_rebase_merge = true + allow_squash_merge = true + allow_update_branch = false + archived = false + default_branch = "main" + delete_branch_on_merge = false + dependabot_alerts_enabled = true + dependabot_security_updates_enabled = true + description = "Project-level settings, resources and discussions" + gh_pages_build_type = "disabled" + has_discussions = true + has_issues = true + has_projects = true + has_wiki = true + homepage = "https://thingweb.io" + is_template = false + merge_commit_message = "PR_TITLE" + merge_commit_title = "MERGE_MESSAGE" + name = ".github" + private = false + secret_scanning = "enabled" + secret_scanning_push_protection = "enabled" + squash_merge_commit_message = "COMMIT_MESSAGES" + squash_merge_commit_title = "COMMIT_OR_PR_TITLE" + template_repository = null + topics = [ + "iot" + "web" + "organization" + ], + web_commit_signoff_required = false + } Plan: 1 to add, 0 to change, 0 to delete. ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-thingweb[id=eclipse-thingweb] --- original +++ canonical @@ -19,15 +19,14 @@ _repositories+:: [ orgs.newRepo('.github') { allow_update_branch: false, - default_branch: "main", dependabot_security_updates_enabled: true, description: "Project-level settings, resources and discussions", has_discussions: true, homepage: "https://thingweb.io", topics+: [ "iot", - "web", - "organization" + "organization", + "web" ], web_commit_signoff_required: false, }, ```
github-actions[bot] commented 1 year ago
Diff for ebc2ec17cdc1dd54adce3260179478aed856f58f: ```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-thingweb[id=eclipse-thingweb] there have been 4 validation infos, enable verbose output with '-v' to to display them. + add repository[name=".github"] { + allow_auto_merge = false + allow_forking = true + allow_merge_commit = true + allow_rebase_merge = true + allow_squash_merge = true + allow_update_branch = false + archived = false + default_branch = "main" + delete_branch_on_merge = false + dependabot_alerts_enabled = true + dependabot_security_updates_enabled = false + description = "Project-level settings, resources and discussions" + gh_pages_build_type = "disabled" + has_discussions = true + has_issues = true + has_projects = true + has_wiki = true + homepage = "https://thingweb.io" + is_template = false + merge_commit_message = "PR_TITLE" + merge_commit_title = "MERGE_MESSAGE" + name = ".github" + private = false + secret_scanning = "enabled" + secret_scanning_push_protection = "enabled" + squash_merge_commit_message = "COMMIT_MESSAGES" + squash_merge_commit_title = "COMMIT_OR_PR_TITLE" + template_repository = null + topics = [ + "iot" + "web" + "organization" + ], + web_commit_signoff_required = false + } Plan: 1 to add, 0 to change, 0 to delete. ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-thingweb[id=eclipse-thingweb] --- original +++ canonical @@ -19,15 +19,13 @@ _repositories+:: [ orgs.newRepo('.github') { allow_update_branch: false, - default_branch: "main", - dependabot_security_updates_enabled: false, description: "Project-level settings, resources and discussions", has_discussions: true, homepage: "https://thingweb.io", topics+: [ "iot", - "web", - "organization" + "organization", + "web" ], web_commit_signoff_required: false, }, ```
netomi commented 1 year ago

If you want to enable organization wide discusssions, you will have to set has_discussions to true for organization settings and specify discussion_source_repository to the .github repo.

danielpeintner commented 1 year ago

Proposed PR looks good to me with the changes/updates proposed by @netomi (hence I wait before approving...)

github-actions[bot] commented 1 year ago
Diff for a34e086a97477b449ebc52d7d1af460b3ab86643: ```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-thingweb[id=eclipse-thingweb] ╷ │ Error: failed to load configuration │ │ failed to evaluate jsonnet file: /home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/orgs/eclipse-thingweb/eclipse-thingweb.jsonnet:20:24 Couldn't lex verbatim string, junk after '@': 101 │ │ email: thingweb-dev@eclipse.org, │ ╵ ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-thingweb[id=eclipse-thingweb] ╷ │ Error: failed to load configuration: failed to evaluate jsonnet file: /home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/orgs/eclipse-thingweb/eclipse-thingweb.jsonnet:20:24 Couldn't lex verbatim string, junk after '@': 101 │ │ │ email: thingweb-dev@eclipse.org, │ ╵ ```
egekorkan commented 1 year ago

I have incorporated the changes and did the other changes:

github-actions[bot] commented 1 year ago
Diff for 6700cf6b28ae7bea0ed941b9f0e926f882dcabfd: ```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-thingweb[id=eclipse-thingweb] ╷ │ Error: failed to load configuration │ │ failed to evaluate jsonnet file: /home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/orgs/eclipse-thingweb/eclipse-thingweb.jsonnet:20:5-10 Expected a comma before next field │ │ email: "thingweb-dev@eclipse.org", │ ╵ ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-thingweb[id=eclipse-thingweb] ╷ │ Error: failed to load configuration: failed to evaluate jsonnet file: /home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/orgs/eclipse-thingweb/eclipse-thingweb.jsonnet:20:5-10 Expected a comma before next field │ │ │ email: "thingweb-dev@eclipse.org", │ ╵ ```
github-actions[bot] commented 1 year ago
Diff for f3da040113172e54e2a11aa0be78a0cccab19f5d: ```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-thingweb[id=eclipse-thingweb] there have been 4 validation infos, enable verbose output with '-v' to to display them. ! settings { ! description = "" -> "Components for making IoT solutions interoperable at scale by leveraging the W3C WoT standards, no matter if improving an existing solution or building a new one" ! discussion_source_repository = null -> ".github" ! email = null -> "thingweb-dev@eclipse.org" ! has_discussions = false -> true ! } + add repository[name=".github"] { + allow_auto_merge = false + allow_forking = true + allow_merge_commit = true + allow_rebase_merge = true + allow_squash_merge = true + allow_update_branch = true + archived = false + default_branch = "main" + delete_branch_on_merge = false + dependabot_alerts_enabled = true + dependabot_security_updates_enabled = false + description = "Project-level settings, resources and discussions" + gh_pages_build_type = "disabled" + has_discussions = false + has_issues = true + has_projects = true + has_wiki = true + homepage = "https://thingweb.io" + is_template = false + merge_commit_message = "PR_TITLE" + merge_commit_title = "MERGE_MESSAGE" + name = ".github" + private = false + secret_scanning = "enabled" + secret_scanning_push_protection = "enabled" + squash_merge_commit_message = "COMMIT_MESSAGES" + squash_merge_commit_title = "COMMIT_OR_PR_TITLE" + template_repository = null + topics = [ + "iot" + "web" + "organization" + ], + web_commit_signoff_required = false + } Plan: 1 to add, 4 to change, 0 to delete. ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-thingweb[id=eclipse-thingweb] --- original +++ canonical @@ -6,6 +6,9 @@ default_workflow_permissions: "write", dependabot_security_updates_enabled_for_new_repositories: false, description: "Components for making IoT solutions interoperable at scale by leveraging the W3C WoT standards, no matter if improving an existing solution or building a new one", + discussion_source_repository: ".github", + email: "thingweb-dev@eclipse.org", + has_discussions: true, members_can_change_project_visibility: false, members_can_change_repo_visibility: true, members_can_delete_repositories: true, @@ -15,20 +18,15 @@ readers_can_create_discussions: true, two_factor_requirement: false, web_commit_signoff_required: false, - has_discussions: true, - discussion_source_repository: ".github", - email: "thingweb-dev@eclipse.org", }, _repositories+:: [ orgs.newRepo('.github') { - dependabot_security_updates_enabled: false, description: "Project-level settings, resources and discussions", - has_discussions: false, homepage: "https://thingweb.io", topics+: [ "iot", - "web", - "organization" + "organization", + "web" ], web_commit_signoff_required: false, }, ```
netomi commented 1 year ago

the change has been applied.

Fyi: changes have to be applied manually for now after a PR has been merged. It uses some command line tool to do the change, but it still requires someone to manually run the tool.

In your case, I have run into some small issues when trying to apply the changes, thats why it took a bit of time. The changes are now live. For the organization description: I have realized now that GitHub has a maximum of 160 chars for the description, so I shortened the one you provided.

For the discussion_source_repository, you need to specify the full slug including the owner like that: "eclipse-thingweb/.github"

I have added this validation rules in the meantime to the tool so that we can avoid that confusion in the future.

egekorkan commented 1 year ago

Ok I see, I thought it was automated but this is also fine :)

The description looks fine, thanks!