search

eclipse-thingweb / td-tools

Utility libraries for W3C Thing Descriptions and Thing Models
https://thingweb.io
Other
4 stars 3 forks source link

feat: allow to configure aasId and aasIdShort #53

Closed danielpeintner closed 1 month ago

danielpeintner commented 1 month ago

fixes https://github.com/eclipse-thingweb/td-tools/issues/50

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.23%. Comparing base (fc146ca) to head (3b1c68c).

Files with missing lines Patch % Lines
node/aas-aid/src/asset-interfaces-description.ts 0.00% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #53 +/- ## ========================================== - Coverage 65.59% 65.23% -0.36% ========================================== Files 1 1 Lines 558 558 Branches 222 224 +2 ========================================== - Hits 366 364 -2 Misses 155 155 - Partials 37 39 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danielpeintner commented 1 month ago

@egekorkan please take a look and let me know whether that's how you envision it to look like...

egekorkan commented 1 month ago

@egekorkan please take a look and let me know whether that's how you envision it to look like...

Yup that is what I had in mind. Just going to confirm with another developer as well

egekorkan commented 1 month ago

Works as expected by users, merging