eclipse-tractusx / portal-frontend

Portal Frontend
Apache License 2.0
5 stars 35 forks source link

fix: user role description translations in en/de #1287

Open Usmanfee opened 4 weeks ago

Usmanfee commented 4 weeks ago

Description

Updated the CSV file parsing journey in order to extract the German language translations for User role's description in process of App creation.

Changelog entry:

- **App Access Management**
  - Added support to fetch German language translation from CSV file template for app User role [#1288](https://github.com/eclipse-tractusx/portal-frontend/issues/1288)

Why

we weren't handling the User Role's description in German language from CSV file template.

Issue

https://github.com/eclipse-tractusx/portal-frontend/issues/1288

Checklist

sonarcloud[bot] commented 4 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

evegufy commented 3 weeks ago

@kunalgaurav-bmw @lavanya-bmw @manojava-gk please review

Usmanfee commented 2 weeks ago

Absolutely! However, as per my understanding, this is not a translation for some static labels or text. Instead, it pertains to user-driven role description translations, which are always handled through CSV uploads during the app creation phase. Based on the requirement, I made an addition to support the DE language, as per the reported bug.

I also discussed this with @ybidois . The CSV upload process needs to be reconsidered to allow users the flexibility to edit role descriptions. Additionally, we need to evaluate how the UI will look if we expand to more than two languages. For the scope of this ticket, the bug needs to be resolved, but a discussion with UX is required before making any UI changes for role descriptions.

@MaHa-2212 / @dorkabcox