ci: modify dependencies check on DEPENDENCIES updates

eclipse-tractusx / portal-frontend

Portal Frontend

Apache License 2.0

5 stars 35 forks source link

ci: modify dependencies check on DEPENDENCIES updates #1320

Closed typecastcloud closed 2 weeks ago

typecastcloud commented 2 weeks ago

Description

Also trigger dependencies.yaml workflow on changes to dependencies.yaml and DEPENDENCIES file.

Why

Prevent wrong/accidental changes to DEPENDENCIES file. Improvement to changes in eclipse-tractusx/portal-frontend#1310.

Issue

Refs: eclipse-tractusx/portal-frontend#1306

Checklist

[x] I have followed the contributing guidelines
[x] I have performed IP checks for added or updated 3rd party libraries
[x] I have performed a self-review of my own code

sonarcloud[bot] commented 2 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

typecastcloud commented 2 weeks ago

really like that, I think we should add that to our other repos as well

Hi Phil, see

eclipse-tractusx/portal-frontend-registration#301
eclipse-tractusx/portal-shared-components#388 for other frontend repositories.

For C# projects maybe only triggering on change to *.csproj files would work and follow guidelines. Would that cover all dependency changes?

Phil91 commented 2 weeks ago

really like that, I think we should add that to our other repos as well

Hi Phil, see

ci: modify dependencies check to run on DEPENDENCIES updates portal-frontend-registration#301

ci: modify dependencies check to run on DEPENDENCIES updates portal-shared-components#388 for other frontend repositories.

For C# projects maybe only triggering on change to *.csproj files would work and follow guidelines. Would that cover all dependency changes?

yes I think the filter for *.csproj makes sense