refactor: optimize CardChip component - Githubissues

eclipse-tractusx / portal-shared-components

Portal Shared UI Components

https://eclipse-tractusx.github.io/portal-shared-components

Apache License 2.0

2 stars 14 forks source link

refactor: optimize CardChip component #310

Closed shahmargi12 closed 2 months ago

shahmargi12 commented 2 months ago

Description

Removed state management: Eliminated useState and useEffect for managing chip colors and backgrounds.
Optimized style handling: Directly applied styles using the static mapping instead of dynamic calculations.
Improved component performance: Reduced unnecessary re-renders.
Enhanced code maintainability: Simplified code by using a static configuration, making it easier to maintain.

Why

To improve performance by eliminating use of states within the component.
To enhance code readability and maintainability by simplifying status-to-style mapping.

Issue

Checklist

[x] I have followed the contributing guidelines
[x] I have performed a self-review of my own code
[x] I have successfully tested my changes locally

shahmargi12 commented 2 months ago

Kindly resolve conflicts occurring due to PR #309 enforcing import order

@oyo, the conflicts have been resolved.

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud