search

eclipse-tractusx / tractus-x-umbrella

Where all Tractus-X comes together
Apache License 2.0
12 stars 24 forks source link

[Discoveryfinder][BpnDiscovery][SemanticHub] Upgrade to R24.08 #148

Closed tunacicek closed 3 weeks ago

tunacicek commented 1 month ago

Description

Update discoveryfinder to 0.3.1 Update bpndiscovery to 0.3.1 Update semantic-hub to 0.3.1

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

evegufy commented 3 weeks ago

Hi @tunacicek LGTM in general but just a question which was on my mind for quite some time: Don't you need to configure the following service accounts somewhere for the discovery services?:

I can't find this config:

tunacicek commented 3 weeks ago

Hi @tunacicek LGTM in general but just a question which was on my mind for quite some time: Don't you need to configure the following service accounts somewhere for the discovery services?:

I can't find this config:

Thanks for your review and feedback @evegufy . You are right. I kept it simple and left out the entry for discovery finder (because it's not mandatory). I will take a look - Maybe instead of using the credentials for self registration, i will add the entry directly in discoveryfinder.

tunacicek commented 3 weeks ago

@evegufy I Add the credentials for self registration