fix(dataexchange): change to http connection and add config

evegufy commented 6 months ago

Description

add config in adopter values file to make override of relevant values clearer
remove disabled components from adopter values file as they defaulting to disabled by now
why no tls connection?:
- tls.crt from root-secret can't get imported into truststore of the tractusx-connector, at least not automatically: the customCaCerts option exists but that would require to copy the autogenerated tls.crt into the values file
- when attempting the option with customCaCerts, the flow doesn't e2e due to the miw being unable to verify the jwt signature of the centralidp, even if the tls.crt from the root-secret is imported into the truststore of the miw

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

gitguardian[bot] commented 6 months ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [10817586](https://dashboard.gitguardian.com/workspace/226265/incidents/10817586?occurrence=133004151) | Triggered | Generic High Entropy Secret | 546644d8720e1f4980bb16af65ccd784e8d44dfb | charts/umbrella/values-adopter-data-exchange.yaml | [View secret](https://github.com/eclipse-tractusx/tractus-x-umbrella/commit/546644d8720e1f4980bb16af65ccd784e8d44dfb#diff-332eab34d7cc167ad0b87aceb53342c2b531dad809b3af2a84f83ace56fa4faeR71) | | [10817587](https://dashboard.gitguardian.com/workspace/226265/incidents/10817587?occurrence=133004152) | Triggered | Generic High Entropy Secret | 546644d8720e1f4980bb16af65ccd784e8d44dfb | charts/umbrella/values-adopter-data-exchange.yaml | [View secret](https://github.com/eclipse-tractusx/tractus-x-umbrella/commit/546644d8720e1f4980bb16af65ccd784e8d44dfb#diff-332eab34d7cc167ad0b87aceb53342c2b531dad809b3af2a84f83ace56fa4faeR114) |

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

JohannesARENA2036 commented 6 months ago

Successfully tested, work for single user enviroment.

eclipse-tractusx / tractus-x-umbrella