HttpRequestImpl#connectTimeout does not support Fluent

[bennygao]

Questions

In implements code of io.vertx.ext.web.client.impl.HttpRequestImpl#connectTimeout, it is supposed to return this, but it returns nullinstead, causing a NullPointerExceptionwhen setting other options of HttpRequest in a Fluent manner after connectTimeout.

    public HttpRequest<T> connectTimeout(long timeout) {
        this.connectTimeout = timeout;
        return null; // -> return this;
    }

For example:

webClient.requestAbs(method, absoluteURI)
        .connectTimeout(5000)
        .idleTimeout(60000) // NullPointerException here
    .putHeader("Content-Type", "application/json")
    .sendBuffer(buffer, asyncResult -> {
            ... ...
        });

Version

4.5.8

[tsegismont]

Nice catch, thank you @bennygao !

[tsegismont]

Fixed by https://github.com/vert-x3/vertx-web/commit/c96962a0c7a2f3fb9a33b2474fdacd9ee673261c