eclipse-vertx / vertx-auth

Apache License 2.0
166 stars 156 forks source link

TPM PubArea buffer position incorrect #684

Open podlesrafal opened 2 months ago

podlesrafal commented 2 months ago

Here is an issue with buffer position: https://github.com/eclipse-vertx/vertx-auth/blob/84647f46ec0e7641ea420794994f9a79a2b9a3be/vertx-auth-webauthn/src/main/java/io/vertx/ext/auth/webauthn/impl/attestation/tpm/PubArea.java#L63 According to TPM 2.0 documentation, curveID has length of 2 bytes. This causes problem with reading length of unique I prepared fix, but I dont have access to push.

vietj commented 2 months ago

you need to do a pull request

podlesrafal commented 2 months ago

I cant push branch with change - ERROR: Permission to eclipse-vertx/vertx-auth.git denied to podlesrafal.