search

eclipse-windowbuilder / windowbuilder

Eclipse Windowbuilder
https://projects.eclipse.org/projects/tools.windowbuilder
Eclipse Public License 1.0
80 stars 30 forks source link

Remove support for the deleted Databinding API #492

Open ptziegler opened 1 year ago

ptziegler commented 1 year ago

Related to #491. There are several locations where WindowBuilder:

a) Makes several case-distinctions between the old and new Observable API b) Creates a bi-directional mapping between methods of the new API to the old API

Keeping the former is a real pain in terms of maintainability. Latter falls apart because both versions are not 100% compatible. Example: SWTObservables.observeSelection() can be any of WidgetProperties.widgetSelection(), WidgetProperties.dateTimeSelection(), ... And this problem will only increase, the more features are added to the new API.

Given that the old API is gone for good, I don't think it makes any sense for WindowBuilder to keep referencing it internally or even generate code for it.

wimjongman commented 1 year ago

I agree. Support can be dropped for the old binding classes.