search

eclipse / Xpect

This repository has been rewritten to move to the Eclipse Foundation. Find the old history here: https://github.com/TypeFox/Xpect
http://www.xpect-tests.org/
Eclipse Public License 2.0
30 stars 28 forks source link

Modernize Xpect #324

Closed tjeske closed 11 months ago

tjeske commented 1 year ago

Resolves #320

cdietrich commented 1 year ago

@szarnekow @iloveeclipse would be nice if you also could have a look

cdietrich commented 1 year ago

nice change. great achievement

TODO / pot. follow ups

cdietrich commented 1 year ago 
org.eclipse.xpect/META-INF/MANIFEST.MF:Require-Bundle: org.eclipse.xpect.mwe2;bundle-version="0.2.0",
org.eclipse.xtext.example.domainmodel.xpect.tests/META-INF/MANIFEST.MF: org.eclipse.xpect.xtext.lib;bundle-version="0.2.0",
org.eclipse.xtext.example.domainmodel.xpect.tests/META-INF/MANIFEST.MF: org.eclipse.xpect.xtext.xbase.lib;bundle-version="0.2.0",

might want to bump versions here too

tjeske commented 1 year ago

nice change. great achievement

TODO / pot. follow ups

* Deprecated XMLReaderFactory

* unused imports

* set minimal java version to 17

* use mwe 2.15 release in nightly target

* use 2023-09 in nightly target

* use newer orbit (check xtext targets)

Thanks for having a look!

I didn't want to replace the Java XMLReaderFactory stuff in this PR, but after a closer look I think it is not a big change. I will give it a try tomorrow.

Okay, if nobody is on Java 11 anymore, I set minimum Java version to 17 and switch to latest Eclipse release.

I will refresh the deps etc. tomorrow.

cdietrich commented 1 year ago

We can do the Java 17 move to a second step / pr

kuniss commented 1 year ago

Okay, if nobody is on Java 11 anymore, I set minimum Java version to 17 and switch to latest Eclipse release.

Is there really a need to switch to Java 17? As long as Java 11 LTS is running we may stay with it? I would switch to Java 17 when Eclipse is requiring Java 17...

tjeske commented 1 year ago

Okay, if nobody is on Java 11 anymore, I set minimum Java version to 17 and switch to latest Eclipse release.

Is there really a need to switch to Java 17? As long as Java 11 LTS is running we may stay with it? I would switch to Java 17 when Eclipse is requiring Java 17...

Eclipse 2023-06 requires Java >= 17.

kuniss commented 1 year ago

Okay, if nobody is on Java 11 anymore, I set minimum Java version to 17 and switch to latest Eclipse release.

Is there really a need to switch to Java 17? As long as Java 11 LTS is running we may stay with it? I would switch to Java 17 when Eclipse is requiring Java 17...

Eclipse 2023-06 requires Java >= 17.

Guess, I'm out of date... :smile:

cdietrich commented 12 months ago

changes look good so far, but i still want to set this up locally to see how workspace looks like. anyway i propose to bring a first version to the mondernize branch so this can be tested more broadly