update nightly target platform

eclipse / Xpect

This repository has been rewritten to move to the Eclipse Foundation. Find the old history here: https://github.com/TypeFox/Xpect

http://www.xpect-tests.org/

Eclipse Public License 2.0

30 stars 28 forks source link

Open tjeske opened 10 months ago

cdietrich commented 10 months ago

@tjeske can you please rebase the pr

cdietrich commented 10 months ago

i assume we

szarnekow commented 10 months ago

I didn't understand the suggestion (3)

maybe we can also import classgraph? do we need the reexport?

What you you mean by that?

cdietrich commented 10 months ago

import page should be same accross old/new. (if xtext would have import package) maybe we also need to change xtext to make import non optional

cdietrich commented 10 months ago

proposal:

first merge https://github.com/eclipse/Xpect/compare/cd_classgraph then rebase this branch then always pull the new classgraph plugin to the update site (also in the old one)

@szarnekow @tjeske what do you think. also: should we do an import package on xtext side?

cdietrich commented 10 months ago

ping @szarnekow

szarnekow commented 10 months ago

I agree with your proposal. I don't quite understand the relation between Xtext import-package and this PR here.

cdietrich commented 10 months ago

Relation is indirect. Same problem different place

cdietrich commented 10 months ago

szarnekow commented 10 months ago

Ah, that one... Changed bundle ID due to different packaging. Yeah, import package should be preferred for these.