Closed merks closed 10 months ago
@cdietrich @tjeske
Guys, I see that for my safety and comfort the PR build doesn't actually use my modified Jenkinsfile.
I've switched to use Tycho 4.0.3 which required Maven 3.9.x and Java 17, so this just don't work in the PR build.
But I can assure you that the builds really do work and demonstrated here:
https://ci.eclipse.org/oomph/job/internal/job/xpect/job/master/
How best can we get past this impasse?
If someone merges these changes, I'll be able to modify the Oomph project catalog to point at the new setup and I can help fix any problems that may arise. I have some time today and some time tomorrow morning. Then my time gets more spotty...
Note that these changes are tested that the nightly target platform works again so this should get things back into good shape.
pushed to https://github.com/eclipse/Xpect/tree/merks-issue-328 so that jenkins actually builds it
both builds with the targets worked. the promotion we will see only when merged.
are you going to push something for matrix?
I assume you have to work your magic again for this force push...
yes. pushed again
I force pushed again because I saw a warning about the test reports. So I changed that to use the pattern of the older script...
Hopefully this is the last change!
pushed your branch again
test results published too. ready to merge?
The tests results warning is gone. I can't tell if the matrix thing is kicking in.
It should:
READY!
Then I can change the Oomph project catalog and do a bit more testing! Woo hoo!
good question. in xtext we dont have an extra function. i introduced this cause it was to only way to get it running with old pipeline. at the same time it also just reports if build result changes.
=> can you move it to cleanup as in Xtext and mwe https://github.com/eclipse/xtext/blob/4dd77f11cf279f2ede8036adb5f951315b1e9b35/Jenkinsfile#L99C7-L99C7 https://github.com/eclipse/mwe/blob/62067fa5f0a40dc58cfb4cf38a0f9e0ce98809e8/Jenkinsfile#L225
always wont be called on abort as it seems. started again and the success is shown
I see. I will make that change. Also I'll add some echo so that we can see what's checking and doing.
works as expected. maybe thanks. gonna push the button
many thanks @merks
Likewise many thanks to you too!!!
Improve the bundle names as they appear in the update sites. Upgrade to latest Tycho release. Upgrade to the latest jarsigner. Provide a functional Oomph setup, including a setup configuration and use it in the CONTRIBUTING.md. Ensure that the nightly target works. Reduce workspace warnings.
https://github.com/eclipse/Xpect/issues/328 https://github.com/eclipse/Xpect/issues/330