search

eclipse / Xpect

This repository has been rewritten to move to the Eclipse Foundation. Find the old history here: https://github.com/TypeFox/Xpect
http://www.xpect-tests.org/
Eclipse Public License 2.0
30 stars 28 forks source link

Cannot build Xpect against latest Eclipse SDK integration build (4.32_I20240502-1800) #339

Closed trancexpress closed 3 months ago

trancexpress commented 3 months ago

When trying to build Xpect against "latest" Eclipse SDK integration build, I run into the following error:

[INFO] ----------------< org.eclipse.xpect:org.eclipse.xpect >-----------------
[INFO] Building org.eclipse.xpect 0.3.0-SNAPSHOT                         [3/14]
[INFO]   from org.eclipse.xpect/pom.xml
[INFO] ---------------------------[ eclipse-plugin ]---------------------------
[WARNING] Using JavaSE-17 to fulfill requested profile of JavaSE-11 this might lead to faulty dependency resolution, consider define a suitable JDK in the toolchains.xml
[INFO] Resolving dependencies of MavenProject: org.eclipse.xpect:org.eclipse.xpect:0.3.0-SNAPSHOT @ /data/git/Xpect/org.eclipse.xpect/pom.xml
[INFO] {osgi.os=macosx, osgi.ws=cocoa, org.eclipse.update.install.features=true, osgi.arch=x86_64}
[ERROR] Cannot resolve project dependencies:
[ERROR]   You requested to install 'org.eclipse.equinox.p2.iu; org.apache.commons.logging 0.0.0' but it could not be found
[ERROR] 
[ERROR] See https://wiki.eclipse.org/Tycho/Dependency_Resolution_Troubleshooting for help.

It looks like org.apache.commons.logging is no longer included in the SDK build. So this line seems to be necessary?

diff --git a/org.eclipse.xpect.releng/target-platforms/eclipse_2023_09-xtext_nightly/org.eclipse.xpect.target.eclipse_2023_09-xtext_nightly.target b/org.eclipse.xpect.releng/target-platforms/eclipse_2023_09-xtext_nightly/org.eclipse.xpect.target.eclipse_2023_09-xtext_nightly.target
index 4dc3563..32912a5 100644
--- a/org.eclipse.xpect.releng/target-platforms/eclipse_2023_09-xtext_nightly/org.eclipse.xpect.target.eclipse_2023_09-xtext_nightly.target
+++ b/org.eclipse.xpect.releng/target-platforms/eclipse_2023_09-xtext_nightly/org.eclipse.xpect.target.eclipse_2023_09-xtext_nightly.target
@@ -23,6 +23,7 @@
 <repository location="https://download.eclipse.org/releases/2023-09"/>
 </location>
 <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
+<unit id="org.apache.commons.logging" version="0.0.0"/>
 <unit id="org.hamcrest.core" version="2.2.0.v20230809-1000"/>
 <unit id="org.hamcrest.core.source" version="2.2.0.v20230809-1000"/>
 <unit id="org.junit" version="4.13.2.v20230809-1000"/>
cdietrich commented 3 months ago

Do you have an idea why https://ci.eclipse.org/xpect/job/Xpect/job/master/ is green

iloveeclipse commented 3 months ago

Do you have an idea why https://ci.eclipse.org/xpect/job/Xpect/job/master/ is green

Because it still builds against 2023.09 release?

cdietrich commented 3 months ago

Then this should be fixed too Same for other deps in build against nightly

cdietrich commented 3 months ago

i also wonder where in the dependency chain it is missing

cdietrich commented 3 months ago

i wonder if e.g. it should be added to xtext update site instead and or mwe update site

cdietrich commented 3 months ago

@szarnekow do you know which codepaths in xtext/mwe actually use/need it?

cdietrich commented 3 months ago

to me it looks like its needed for mwe

cdietrich commented 3 months ago

https://github.com/eclipse/mwe/pull/290

cdietrich commented 3 months ago

and here we then should use newer mwe

cdietrich commented 3 months ago

done

trancexpress commented 3 months ago

@cdietrich the build fails again with latest SKD integration build. Its successful if I do this change?

diff --git a/org.eclipse.xpect.releng/target-platforms/eclipse_2024_06-xtext_nightly/org.eclipse.xpect.target.eclipse_2023_09-xtext_nightly.target b/org.eclipse.xpect.releng/target-platforms/eclipse_2024_06-xtext_nightly/org.eclipse.xpect.target.eclipse_2023_09-xtext_nightly.target
index e99e594..16f8735 100644
--- a/org.eclipse.xpect.releng/target-platforms/eclipse_2024_06-xtext_nightly/org.eclipse.xpect.target.eclipse_2023_09-xtext_nightly.target
+++ b/org.eclipse.xpect.releng/target-platforms/eclipse_2024_06-xtext_nightly/org.eclipse.xpect.target.eclipse_2023_09-xtext_nightly.target
@@ -16,6 +16,7 @@
 </location>
 <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
 <unit id="org.eclipse.emf.mwe2.launcher.feature.group" version="0.0.0"/>
+<unit id="org.apache.commons.logging" version="0.0.0"/>
 <repository location="file:///data/git/mwe/maven/org.eclipse.emf.mwe2.repository/target/repository/"/>
 </location>
 <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">

Is something missing still?

cdietrich commented 3 months ago

https://ci.eclipse.org/xpect/job/Xpect/job/master/ is green

which mwe repo do you use?

what is error mesage you get

cdietrich commented 3 months ago

also +<unit id="org.apache.commons.logging" version="0.0.0"/> should not be needed explicitely

trancexpress commented 3 months ago

which mwe repo do you use?

Locally built mwe, so that we have latest mwe.

what is error mesage you get

[INFO] {osgi.os=macosx, osgi.ws=cocoa, org.eclipse.update.install.features=true, osgi.arch=x86_64}
[ERROR] Cannot resolve project dependencies:
[ERROR]   You requested to install 'org.eclipse.equinox.p2.iu; org.apache.commons.logging 0.0.0' but it could not be found
[ERROR] 
[ERROR] See https://wiki.eclipse.org/Tycho/Dependency_Resolution_Troubleshooting for help.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for org.eclipse.xpect.root 0.3.0-SNAPSHOT:
[INFO] 
[INFO] org.eclipse.xpect.parent ........................... SUCCESS [  0.095 s]
[INFO] org.eclipse.xpect.mwe2 ............................. SUCCESS [ 28.291 s]
[INFO] org.eclipse.xpect .................................. FAILURE [  0.043 s]
[INFO] org.eclipse.xpect.ide .............................. SKIPPED
[INFO] org.eclipse.xpect.ui ............................... SKIPPED
[INFO] org.eclipse.xpect.ui.junit ......................... SKIPPED
[INFO] org.eclipse.xpect.xtext.lib ........................ SKIPPED
[INFO] org.eclipse.xpect.xtext.xbase.lib .................. SKIPPED
[INFO] org.eclipse.xpect.xtext.lib.feature ................ SKIPPED
[INFO] org.eclipse.xpect.xtext.xbase.lib.feature .......... SKIPPED
[INFO] org.eclipse.xpect.sdk .............................. SKIPPED
[INFO] org.eclipse.xpect.repository ....................... SKIPPED
[INFO] org.eclipse.xpect.target.eclipse_2024_06-xtext_nightly SKIPPED
[INFO] org.eclipse.xpect.root ............................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
cdietrich commented 3 months ago

and that mwe contains commons.logging?

trancexpress commented 3 months ago

and that mwe contains commons.logging?

Christian, you can see in my comment with the diff; yes, the local repo has it. The build is successful with this change, but fails without it.

Note that the build was fine for a few days, without this change. Maybe some recent mwe change has an unwanted effect?

cdietrich commented 3 months ago

i dont know. on jenkins it works with no change ?!?!?!? in mwe there was no change to my knowledge that is relevant

cdietrich commented 3 months ago

@trancexpress which tycho do you use? which platform?

cdietrich commented 3 months ago

https://ci.eclipse.org/xpect/job/Xpect/job/cd-jat/1/console

there seems to be jet another crappy platform problem....

are you using i-buidls?

iloveeclipse commented 3 months ago

are you using i-buidls?

Sure. Every Friday I run build based on last nightly from Thursday. This fail today is based on 4.32 M3 platform contribution built yesterday.

cdietrich commented 3 months ago

so the question was was changed between m2 and m3

iloveeclipse commented 3 months ago

See history of https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/master/eclipse.platform.releng.prereqs.sdk/eclipse-sdk-prereqs.target

iloveeclipse commented 3 months ago

https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/commits/master/eclipse.platform.releng.prereqs.sdk/eclipse-sdk-prereqs.target

cdietrich commented 3 months ago

looks like an old tycho version bug. will try to bump

cdietrich commented 3 months ago

@iloveeclipse @trancexpress can you please try the cd-jat branch

trancexpress commented 3 months ago

I'll try in a few hours.

trancexpress commented 3 months ago

@cdietrich the branch cd-jat compiles successfully.

iloveeclipse commented 3 months ago

@cdietrich the branch cd-jat compiles successfully.

Are we done now or should something be merged somewhere?

cdietrich commented 3 months ago

my pr is merged

iloveeclipse commented 3 months ago

Thanks Christian!