search

eclipse / Xpect

This repository has been rewritten to move to the Eclipse Foundation. Find the old history here: https://github.com/TypeFox/Xpect
http://www.xpect-tests.org/
Eclipse Public License 2.0
30 stars 28 forks source link

Add org.apache.commons.logging to units taken from simrel/orbit-aggregation #340

Closed trancexpress closed 3 months ago

trancexpress commented 3 months ago

Fixes: #339

trancexpress commented 3 months ago

@tjeske , can you take a look here please?

cdietrich commented 3 months ago

alternative proposal: https://github.com/eclipse/Xpect/pull/341

cdietrich commented 3 months ago

@trancexpress can you check that with your build

iloveeclipse commented 3 months ago

can you check that with your build

You mean https://github.com/eclipse/Xpect/pull/341? I would just merge it, or is there any catch?

cdietrich commented 3 months ago

Yes but I don’t know what exactly you do in your. Build

iloveeclipse commented 3 months ago

Yes but I don’t know what exactly you do in your. Build

We patch the build to build against latest (local) SDK build, that's all the difference.

cdietrich commented 3 months ago

I merged and will close here

iloveeclipse commented 3 months ago

Thanks Christian!