search

eclipse / aCute

Eclipse aCute - C# edition in Eclipse IDE
https://projects.eclipse.org/projects/tools.acute
Eclipse Public License 2.0
78 stars 33 forks source link

Fix for issue #185 and #187 #188

Closed scheind closed 1 year ago

scheind commented 1 year ago

Sorry for not creating the PR sooner. Kinda lost track of it

eriawan commented 1 year ago

@scheind Please fulfill the Eclipse ECA agreement first. Thanks in advance!

mickaelistria commented 1 year ago

Can you please sign the Eclipse contributor agreement https://accounts.eclipse.org/user/login?destination=legal/eca/validation/129563 ?

scheind commented 1 year ago

So I created a account at eclipse and signed the ECA but it still says that it could not validate the sign-off status. Do I have to do something additionally?

eriawan commented 1 year ago

@scheind

Could you please check the email address is matched with the email you register for Eclipse?

scheind commented 1 year ago

@eriawan Yes seems to be the same

eriawan commented 1 year ago

@scheind Apologize I couldn't help you further. Maybe @mickaelistria could provide additional help?

mickaelistria commented 1 year ago

I do not see any obvious reason why this would fail; the email address mismatch between the commit author and the Eclipse account is indeed the usual suspect, but if this is not the cause here, I don't know what else to suggest. Maybe @waynebeaton can tell more...

akurtakov commented 1 year ago

Would you also please rebase on top of master where build should be fixed and your changes should hopefully fix the failing tests.

akurtakov commented 1 year ago

I've tried this patch on top of master with dotnet 6 and new wizard still doesn't have templates.

waynebeaton commented 1 year ago

Whatever was the problem, it appears to have been fixed (note that if you follow the "Details" link, you can rerun the validation).

As a matter of practice, open an issue against the Eclipse Foundation help desk when you encounter these sorts of problems. The IT team are the ones who maintain this infrastructure and we really need them to diagnose these sorts of issues if we have any hope of improving it.

scheind commented 1 year ago

@akurtakov Was this in the tests? I synced the repository and tried it again on my end. I used dotnet 6 and 7 (although not really different) and the templates where displayed.

akurtakov commented 1 year ago

no, I cherry-picked your commit on master locally and tried it. I'll have to look further. Btw, please git rebase on top of master so my commits and your merge commit are gone.

scheind commented 1 year ago

Sorry for the many comments. This is really my first time with git rebase so I'm not to sure. What exactly do I have to do?

akurtakov commented 1 year ago

Assuming you have this repo as "upstream" remote (added via git remote add upstream https://github.com/eclipse/aCute) you should be able to do git rebase upstream/master. Due to the merge commit you may have to do some extra work though:

scheind commented 1 year ago

I assume it should look something like this then: image

And after that a simple push correct?

akurtakov commented 1 year ago

Not familiar with the tool used . Just push it :)

scheind commented 1 year ago

ok pushed it and it says "everything up-to-date"

eriawan commented 1 year ago

@scheind could you fix the test failures?

scheind commented 1 year ago

@eriawan The test failures in Jenkins seem to be related to another issue since it couldn't find the menu bar for the shell.

But I don't know enough about SWTBotTest or how it works.

eriawan commented 1 year ago

@scheind OK, we could fix that later. I have tested this, and it's surely LGTM. Thanks for the contribution!

Currently next week I'm going to focus on my own daily works on some on .NET Core, including some works on NET 7.0 too. Then have a long vacation starting from mid December. I'm going to approve this, but please ensure that you have some screenshots and captures that this PR works, then I'll try to merge this before mid December.

eriawan commented 1 year ago

To other collaborators, feel free to chime in. 🙂

scheind commented 1 year ago

Thanks and sorry I couldn't be of more help with the tests. Here are the screenshots from my system:

Tried it with dotnet version 6 and 7: image

Result when running the plugin and creating a new project: image

eriawan commented 1 year ago

Thanks and sorry I couldn't be of more help with the tests. Here are the screenshots from my system:

Tried it with dotnet version 6 and 7: image

Result when running the plugin and creating a new project: image

Thanks for the screenshots! Yes, I also have tested this myself. ✔️ I'm going to merge this now.

Again, thanks for the contribution! 👍

scheind commented 1 year ago

Yes no problem, despite being a little late (3 months or so :smile: ) And hope you have a great vacation in december :+1: