search

eclipse / microprofile-starter

MicroProfile project generator source code
Apache License 2.0
74 stars 51 forks source link

Web GUI: Gradle option checked: Not all runtimes should be listed #421

Closed Karm closed 3 years ago

Karm commented 3 years ago

image

Emily-Jiang commented 3 years ago

@Karm and @Emily-Jiang used the test UI and found that the GUI was still having issues. If you choose an older version of MP version, such as MP 2.1, TomEE runtime was listed, which should not. Also, if you don't choose MP version, choosing gradle first lists a lot of runtimes that do not support gradle, as shown below.

Emily-Jiang commented 3 years ago
image
Karm commented 3 years ago 
 , TOMEE("tomee", "Apache TomEE 8.0.0-M3",
            Arrays.asList(MicroProfileVersion.MP12, MicroProfileVersion.MP13, MicroProfileVersion.MP14,
                    MicroProfileVersion.MP20, MicroProfileVersion.MP21)
            , "%s-exec.jar" //jarFileName
            , "" //jarParameters // Done by TomeeServer.adaptMavenModel
            , "8080" // portServiceA
            , "8180" //portServiceB // This need to match with Port value from TomeeServer.adjustPOM
            , "https://tomee.apache.org/"
            , true)  // GradleSupport

@Emily-Jiang ^^^ Tomee is marked as supporting Gradle, so it's O.K. actually...

Emily-Jiang commented 3 years ago

@Karm I thought only 3 runtime support Gradle. @rdebusscher can you confirm?

Karm commented 3 years ago

"Support Gradle" is a broad term. Runtime might support gradle, but not a bootable jar way or it requires additional plugin or task etc. So it's not uniformly gradle assembly for all.

See my comments on gitter.

I am leaving Payara, Liberty and Helidon in and I am taking Tomee, Quarkus and Wildfly out of Gradle for the time being.

Tomee: I don't know how to add support for it. Will open an issue and ask.
Wildfly: I am not sure how to handle it the best way, I asked about it on Zulip: https://bit.ly/3gFteD2
Quarkus: I know how to do it, it's just me taking the time to do it, work in progress now...

https://github.com/eclipse/microprofile-starter/pull/427#issuecomment-864897834