search

eclipse / microprofile-starter

MicroProfile project generator source code
Apache License 2.0
74 stars 51 forks source link

Fixes API for lder version without BuildTools, adds tests for API v5 #442

Closed Karm closed 3 years ago

Emily-Jiang commented 3 years ago

@Karm you PR looks good to me. I see you put all latest info to the default json and update the previous version to only support MAVEN. I saw Kumuluzee had test failure. I re-run all tests to see whether the failure was just a glitch.

Karm commented 3 years ago

@Karm you PR looks good to me. I see you put all latest info to the default json and update the previous version to only support MAVEN. I saw Kumuluzee had test failure. I re-run all tests to see whether the failure was just a glitch.

Liberty sometimes glitches, but Kumuluzee fails always on: 

[INFO] Unpacking kumuluzee-loader dependency.
[INFO] Building jar: /home/runner/work/_temp/kumuluzee/target/kumuluzee-uber.jar
[INFO] Repackaging jar: /home/runner/work/_temp/kumuluzee/target/kumuluzee.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  4.774 s
[INFO] Finished at: 2021-09-08T21:24:45Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.kumuluz.ee:kumuluzee-maven-plugin:3.9.0:repackage (package) on project kumuluzee: Execution package of goal com.kumuluz.ee:kumuluzee-maven-plugin:3.9.0:repackage failed.: UnsupportedOperationException -> [Help 1]

...and I don't know why and I cannot reproduce it locally. I tried also locally empty maven repo to let it download everything. I also tried OpenJDK 11.0.13_5 EA. No luck. It runs just fine locally.

Karm commented 3 years ago

@Emily-Jiang I tried to enforce Maven 3.6.3....let's see...

Karm commented 3 years ago

Looks good. Kumuluzee is fixed.

@Emily-Jiang Ack / NAck on this PR?