search

eclipse / microprofile-starter

MicroProfile project generator source code
Apache License 2.0
74 stars 51 forks source link

Update for MP6 #494

Closed majidmostafavi closed 1 month ago

majidmostafavi commented 10 months ago

Add Telemetry update for MP6

majidmostafavi commented 9 months ago

@Emily-Jiang I find the error @Health is deprecated. so I should replace it by @Liveness ,@Readiness.

Emily-Jiang commented 9 months ago

@Emily-Jiang I find the error @health is deprecated. so I should replace it by @Liveness ,@readiness.

Depending on which version of MP health you are talking about. It was only deprecated later. It was fine in the earlier version of MP Health. I suggest you to fix the test error first not to change other things.

Emily-Jiang commented 8 months ago

@luiseufrasio did you figure out what was the test failures and propose a update on the PR to unblock this?

luiseufrasio commented 8 months ago

clipsefdn/eca

@Emily-Jiang the tests seems to be NOT running: https://github.com/eclipse/microprofile-starter/pull/494/checks I says "Workflow runs completed with no jobs"

Emily-Jiang commented 8 months ago

The conflict needs to be solved before the tests can be executed. @majidmostafavi can you please resolve the conflicts and then the CI jobs can be launched?

rdebusscher commented 7 months ago

Why is there a v7 of the Api created when it is identical to v6?

Emily-Jiang commented 7 months ago

Why is there a v7 of the Api created when it is identical to v6?

v7 has Telemetry added though.

rdebusscher commented 7 months ago

The version of the API has nothing to do with the config op the MP versions and the options. It is about the available endpoints, their parameters and responses.

So /api/mpVersion/MP60, /api/7/mpVersion/MP60, and , /api/6/mpVersion/MP60 all return

{"specs":["CONFIG","FAULT_TOLERANCE","JWT_AUTH","METRICS","HEALTH_CHECKS","OPEN_API","REST_CLIENT","TELEMETRY","GRAPHQL"],"supportedServers":["LIBERTY"]}

Even the API versions 2 and higher, all return this result which includes Telemetry.

So there is no need at all to have a new API version.

Emily-Jiang commented 7 months ago

The version of the API has nothing to do with the config op the MP versions and the options. It is about the available endpoints, their parameters and responses.

So /api/mpVersion/MP60, /api/7/mpVersion/MP60, and , /api/6/mpVersion/MP60 all return

{"specs":["CONFIG","FAULT_TOLERANCE","JWT_AUTH","METRICS","HEALTH_CHECKS","OPEN_API","REST_CLIENT","TELEMETRY","GRAPHQL"],"supportedServers":["LIBERTY"]}

Even the API versions 2 and higher, all return this result which includes Telemetry.

So there is no need at all to have a new API version.

I thought the earlier version of MP (1.x-5.x) should NOT return Telemetry @rdebusscher

rdebusscher commented 7 months ago

Earlier versions of MP will not return Telemetry. As I already said, MP Version and API version of the Starter app are 2 independent things.

Emily-Jiang commented 7 months ago

Earlier versions of MP will not return Telemetry. As I already said, MP Version and API version of the Starter app are 2 independent things.

Should the earlier API version such as 2.x return Telemetry at all?

rdebusscher commented 7 months ago

Earlier versions of MP will not return Telemetry. As I already said, MP Version and API version of the Starter app are 2 independent things.

Should the earlier API version such as 2.x return Telemetry at all?

In my opinion, yes. Those that make an integration with the API should not use latest version since that can have breaking changes at any time. Only a certain API version is stable. And having all options in all API versions doesn't force external parties to update their integration with the MP Starter API.

Emily-Jiang commented 7 months ago

Earlier versions of MP will not return Telemetry. As I already said, MP Version and API version of the Starter app are 2 independent things.

Should the earlier API version such as 2.x return Telemetry at all?

In my opinion, yes. Those that make an integration with the API should not use latest version since that can have breaking changes at any time. Only a certain API version is stable. And having all options in all API versions doesn't force external parties to update their integration with the MP Starter API.

Thanks @rdebusscher ! @majidmostafavi you don't need to create a new version of the API.

breakponchito commented 1 month ago

@Emily-Jiang @cesarhernandezgt I found the way to fix the issues from the API MicroProfile Starter but I can't add commits on this PR, it seems someone needs to give me some permission:

remote: Permission to majidmostafavi/microprofile-starter.git denied to breakponchito. fatal: unable to access 'https://github.com/majidmostafavi/microprofile-starter.git/': The requested URL returned error: 403 00:12:20.257: [microprofile-starter] git -c credential.helper= -c core.quotepath=false -c log.showSignature=false push --progress --porcelain majid refs/heads/majidMain:main remote: Permission to majidmostafavi/microprofile-starter.git denied to breakponchito. fatal: unable to access 'https://github.com/majidmostafavi/microprofile-starter.git/': The requested URL returned error: 403 probably I should need to recreate the PR

Emily-Jiang commented 1 month ago

@Emily-Jiang @cesarhernandezgt I found the way to fix the issues from the API MicroProfile Starter but I can't add commits on this PR, it seems someone needs to give me some permission:

remote: Permission to majidmostafavi/microprofile-starter.git denied to breakponchito. fatal: unable to access 'https://github.com/majidmostafavi/microprofile-starter.git/': The requested URL returned error: 403 00:12:20.257: [microprofile-starter] git -c credential.helper= -c core.quotepath=false -c log.showSignature=false push --progress --porcelain majid refs/heads/majidMain:main remote: Permission to majidmostafavi/microprofile-starter.git denied to breakponchito. fatal: unable to access 'https://github.com/majidmostafavi/microprofile-starter.git/': The requested URL returned error: 403 probably I should need to recreate the PR

@breakponchito it was the branch from @majidmostafavi . I think you can checkout his branch and then do a new PR.

git checkout -b majidmostafavi-main main
git pull https://github.com/majidmostafavi/microprofile-starter.git main
breakponchito commented 1 month ago

@Emily-Jiang @cesarhernandezgt I found the way to fix the issues from the API MicroProfile Starter but I can't add commits on this PR, it seems someone needs to give me some permission: remote: Permission to majidmostafavi/microprofile-starter.git denied to breakponchito. fatal: unable to access 'https://github.com/majidmostafavi/microprofile-starter.git/': The requested URL returned error: 403 00:12:20.257: [microprofile-starter] git -c credential.helper= -c core.quotepath=false -c log.showSignature=false push --progress --porcelain majid refs/heads/majidMain:main remote: Permission to majidmostafavi/microprofile-starter.git denied to breakponchito. fatal: unable to access 'https://github.com/majidmostafavi/microprofile-starter.git/': The requested URL returned error: 403 probably I should need to recreate the PR

@breakponchito it was the branch from @majidmostafavi . I think you can checkout his branch and then do a new PR.

git checkout -b majidmostafavi-main main
git pull https://github.com/majidmostafavi/microprofile-starter.git main

yes I already create a new PR here: https://github.com/eclipse/microprofile-starter/pull/499 it seems that I need an approval from a maintainer

@Emily-Jiang Could you help me with this? image