eclipse / packages

IoT Packages project
https://eclipse.org/packages
Eclipse Public License 2.0
46 stars 66 forks source link

Deployments missing toleration options #527

Open geh1sf opened 7 months ago

geh1sf commented 7 months ago

Hello Team,

Upon reviewing your template files for deployments and stateful sets, I noticed that they lack a specification for tolerations.

Integrating tolerations is crucial if you aim to dedicate a specific group of nodes exclusively for Hono services. While affinity rules are beneficial, they do not prevent other resources from being scheduled on these nodes.

To address this, I suggest incorporating the following line to ensure that only the intended workloads run on the designated nodes:

{{- include "hono.pod.tolerations" $args | nindent 6 }}

This small change will enhance our configuration's precision in resource allocation and maintain operational integrity.

sophokles73 commented 7 months ago

We would be happy to accept a PR :-)